Openbox with rounded corners

Head_on_a_Stick · 2017-01-05 08:18:28

^ I was using my BL system as a test bed, I will look into this tonight.

Thanks for testing!

cpoakes · 2017-01-05 18:39:02

When working from Debian sources plus the patch, openbox v3.6.1 compiles and runs on jessie (x86_64) when configured with:

./configure --prefix=/usr --libdir=/usr/lib/x86_64-linux-gnu

The subsequent "make install" installs libobrender and openbox to the expected locations, and openbox executes without a problem. This was why I suggested HOAS package openbox-3.6.1 as a deb.

HOAS's deb files follow the existing Debian packaging strategy, specifically libobrender32 is not included in the deb file. To compensate, HOAS's package needs to either break precedent and include the libobrender32 library, or comply with precedent and provide two packages (openbox, libobrender32).

And technically, there should be newer versions of lxappearance-obconf and obconf to support the additional 3.6.1 features. As far as 3.5 features go, libraries libobrender32 and libobrender29 are compatible. Jessie lxappearance-obconf and obconf will use libobrender29, and support the v3.5 features without conflict.

So my recommendation for HOAS to package just openbox-3.6.1 for jessie was ill considered. There seem to be at least four packages necessary for full 3.6.1 support. Maybe sticking with 3.5.2 and assigning a different version (openbox_3.5.2+bunsen) would better solve the dpkg vs apt version name conflict.

Last edited by cpoakes (2017-01-05 18:51:22)

Head_on_a_Stick · 2017-01-05 22:32:48

cpoakes wrote:

Maybe sticking with 3.5.2 and assigning a different version (openbox_3.5.2+bunsen) would better solve the dpkg vs apt version name conflict.

Sounds good to me, I won't have time until this weekend though.

Thank you for all your work here, it really is fantastic.

cpoakes · 2017-01-06 01:52:08

Thank you for packaging it for general consumption.

johnraff · 2017-01-06 05:38:10

For 3.6.1 support I think you'd have to add libobt2v5 to the dependencies - libobrender32v5 needs it.

I'll give it a go on a VM and see what happens.

cpoakes · 2017-01-07 18:51:11

ADDITIONAL PATCH UPDATE

The patch was not drawing/redrawing the window frame with rounded corners when an application resized itself (e.g. vlc resizing window after opening a video clip). The patch in the original post is now modified with this correction. If you used the patch before 07 Jan 16, you will need to copy the new version. If you are unsure which version you have, the new version references the date "b/openbox/frame.c 2017-01-06 08:56:08.861765701 -0700". All other original content and instructions in the post remain correct.

Last edited by cpoakes (2017-01-07 18:58:18)

Head_on_a_Stick · 2017-01-07 19:52:39

NOTE: packages removed, links dead.

Use https://forums.bunsenlabs.org/viewtopic … 248#p43248 instead.

~~~~~~~~~~~~

The newly-patched .debs have been built and are ready to download.

Links here:

https://forums.bunsenlabs.org/viewtopic … 870#p42870

At the moment, it's all a bit Heath Robinson and the .deb has to be managed manually and will be overwritten by `apt upgrade` — I will re-package it properly with a different name (as suggested by cpoakes) when I have time, this will make installation directly from my OBS repository much easier.

Last edited by Head_on_a_Stick (2017-01-12 19:52:02)

Head_on_a_Stick · 2017-01-07 21:40:55

NOTE: packages removed, links dead.

Use https://forums.bunsenlabs.org/viewtopic … 248#p43248 instead.

~~~~~~~~~~~~

Right, sample openbox-bunsen packages are now available from my OBS repository and should be directly installable.

Instructions here:

https://software.opensuse.org/download. … box-bunsen

Those commands should be run as root, use this command to attain the relevant permissions beforehand:

sudo -i

Remember to `exit` out of the root shell (or close the terminal) afterwards

The openbox-bunsen package should replace the Debian openbox package so the two can be swapped in and out as required.

Unfortunately, the bunsen-pipemenus package depends on Debian's openbox

For testing purposes, we will do without that for now.

I will add a version of bunsen-pipemenus to my OBS repository with the corrected dependency at a later date.

Watch this space

Last edited by Head_on_a_Stick (2017-01-12 19:52:15)

Head_on_a_Stick · 2017-01-07 22:37:37

NOTE: packages removed, links dead.

Use https://forums.bunsenlabs.org/viewtopic … 248#p43248 instead.

~~~~~~~~~~~~

Head_on_a_Stick wrote:

I will add a version of bunsen-pipemenus to my OBS repository with the corrected dependency at a later date.
Watch this space

Done!

To install the rounded corners version of openbox, add my repositories and then use:

sudo apt install openbox-bunsen bunsen-pipemenus-rounded

This should remove the vanilla openbox & bunsen-pipemenus packages and replace them with the new versions.

To go back to the stock packages, use:

sudo apt install openbox{,-bunsen-} bunsen-pipemenus{,-rounded-}

Last edited by Head_on_a_Stick (2017-01-12 19:52:32)

johnraff · 2017-01-08 06:57:19

HoaS I wonder if something went amiss with the last build process? I've just (directly) downloaded the amd64 and i386 debs and all I could find inside was the DEBIAN directory and the docs.

You might also consider a 'Conflicts: openbox' in D/control since the installed files will override those of the regular openbox. In fact, I'm not sure if re-naming the package is the best way to go here. A different version number instead? That would allow it to carry on using bunsen-pipemenus too.

Head_on_a_Stick · 2017-01-08 11:42:27

johnraff wrote:

HoaS I wonder if something went amiss with the last build process? I've just (directly) downloaded the amd64 and i386 debs and all I could find inside was the DEBIAN directory and the docs.

Yup, that's because I'm an idiot and I forgot to add debian/openbox-bunsen.install

The package is fixed now, thank you for testing.

I did attempt to "test" my package but I forgot to use `apt-get clean` :8

You might also consider a 'Conflicts: openbox' in D/control since the installed files will override those of the regular openbox.

debian/control already has these lines:

Conflicts: openbox
Replaces: openbox

For bunsen-pipemenus-rounded, I have simply changed "openbox" in the dependency field to:

openbox | openbox-bunsen

As a result, if `apt purge openbox-bunsen` is issued, that package will be replaced by the stock Debian openbox version 8)

In fact, I'm not sure if re-naming the package is the best way to go here. A different version number instead? That would allow it to carry on using bunsen-pipemenus too.

Well, I always like to provide a simple method to return to the stock configuration with any of my "tweaks" so this seemed like the best option.

If a version bump is used instead then downgrading with `dpkg --force-downgrade` would be the only way (?).

Last edited by Head_on_a_Stick (2017-01-08 13:17:40)

cpoakes · 2017-01-08 18:17:48

cloverskull wrote:

My understanding of OpenBox is that it's more or less treated as "feature-complete" but I think it would be pretty cool to push this into the codebase. Would this be doable?

After consideration, I've decided not to submit this upstream to openbox. As already noted, the methodology is crude - it simply erases the square corners, does not apply a new border to the curve, and does not use the compositor (leaving jaggy edges). Frankly, this can look bad on themes with high contrast between the window title colors and the border color (like stock themes Clearlooks and Mikachu). As long as the theme border and window title colors are close in value, it is a satisfying workaround but not a general solution for all themes.

It does seem appropriate for a distro (like BL) to distribute the patched version when it also supplies compatible OB themes as the RPi Pixel desktop creators chose to do with their version.

johnraff · 2017-01-09 02:35:29

Head_on_a_Stick wrote:

debian/control already has these lines:
Conflicts: openbox
Replaces: openbox

So it does, and did yesterday too. Sorry, my eyes...

In fact, I'm not sure if re-naming the package is the best way to go here. A different version number instead? That would allow it to carry on using bunsen-pipemenus too.
Well, I always like to provide a simple method to return to the stock configuration with any of my "tweaks" so this seemed like the best option.
If a version bump is used instead then downgrading with `dpkg --force-downgrade` would be the only way (?).

I always just 'apt-get purge' the (local) package then reinstall from the repos in such cases. I haven't tried that with openbox during an X session though... Maybe the necessary stuff would persist in RAM, maybe not. Of course it would be OK if you logged out of X first.

And you are advocating installing from your private repo, which of course would complicate the downgrade a bit. To be honest, I alwqys prefer to download and install such debs manually, unless the repo is being maintained by a large and reliable organization (no offence meant of course). I just don't like the idea of pulling in some other unwanted packages by mistake.

cpoakes wrote:

It does seem appropriate for a distro (like BL) to distribute the patched version when it also supplies compatible OB themes as the RPi Pixel desktop creators chose to do with their version.

Since we would indeed be shipping a matching theme, this sounds like something we could think about for a future BL (Helium?), with some documentation explaining the need to switch to regular openbox for certain themes.

TEST:
On my Virtualbox, after install of openbox-bunsen and bunsen-pipemenus-rounded openbox failed to start. I just got a default terminal on a BL wallpaper - no tint2, conky, right-click menu etc. Closing the terminal with ^d exited the session.

cpoakes · 2017-01-09 03:38:55

johnraff wrote:

Since we would indeed be shipping a matching theme, this sounds like something we could think about for a future BL (Helium?), with some documentation explaining the need to switch to regular openbox for certain themes.

There is no need to switch to regular openbox, setting rc.xml <cornerRadius> to 0 runs normal windows with square corners for any and all themes. And if you delete <cornerRadius> altogether, it defaults to square corners.

Last edited by cpoakes (2017-01-09 03:48:26)

johnraff · 2017-01-09 03:54:44

@cpoakes, I took this to mean that the patched OB would not work well with some themes:

cpoakes wrote:

this can look bad on themes with high contrast between the window title colors and the border color (like stock themes Clearlooks and Mikachu).

So you mean that we would need to ship a different rc.xml with the round-corner OB? And our documentation would need to explain the necessary rc.xml setting for high-contrast themes?

BTW I don't suppose the lack of any <cornerRadius> setting in my test rc.xml would have caused the above OB crash?

cpoakes · 2017-01-09 05:53:59

Clarification: The patched openbox works as normal displaying square corners with any and all themes for:

  <cornerRadius>0</cornerRadius>

or if <cornerRadius> is completely omitted from rc.xml. Square corners are the default; round corners must be explicitly configured with a non-zero value. The high contrast themes only look bad with non-zero values. They look as if someone forgot to draw something - which is the crude but intentional methodology.

If the BL Helium theme is designed with round corners, it will ship with an rc.xml including a non-zero <cornerRadius>. BL documentation would need explain how to restore square corners (delete <cornerRadius> or set it to 0) if the chopped corners look bad with a user theme or just to be rid of round corners.

No Crash: I just verified that my patched openbox-3.5.2 launches (no crash) with 1) no <cornerRadius> field, 2) <cornerRadius> of 0, and 3) <cornerRadius> of 8. I am not using HOAS's packages (still compiling my own), so I cannot rule out anything packaging related.

cpoakes · 2017-01-09 07:21:24

@johnraff - I seem to have replicated your problem on bare metal. 1) I boot the BL iso into openbox/tint2/conky, 2) download and install (dpkg -i) openbox-bunsen*deb bunsen-pipemenus-round*deb, 3) exit the x-session to lightdm, 4) login as user:live, and 5) end up in X with just the x-terminal-emulator (the x-session fallback).

Exiting the shell goes back to the lightdm login and I can explicitly choose an openbox session and login to X with openbox/tint2/conky as expected (with square corners). I can then set <cornerRadius> in <theme> of rc.xml, do "openbox --restart", and have round corners.

It appears that replacing the standard openbox/bunsen-pipemenus with the patched/round versions causes lightdm to lose track of openbox as the default session and starts a default x-terminal-emulator instead. I didn't diagnose any further.

Head_on_a_Stick · 2017-01-09 07:27:22

Thanks for testing, I will look into this tonight.

Sorry for the inconvenience.

cpoakes · 2017-01-09 07:41:08

Thanks for iterating on my changes and debugging the packaging; won't be surprised if this packaging problem is particularly subtle or a side-effect.

Last edited by cpoakes (2017-01-09 07:43:36)

johnraff · 2017-01-09 07:44:55

Just confirmed that the RPi version you posted first built, installed and ran without crashing, but I ran out of time at the patching-the-debian-source version. Let's wait and see what HoaS has to say.

EDIT: posts 37~39 arrived while I was posting - reading them now.

BTW: regarding reverting back to the standard OB after installing from HoaS's repo - would not a simple remove, followed by 'apt-get install -t jessie' do it, even if both packages had the same name?

Last edited by johnraff (2017-01-09 08:26:41)

#21 2017-01-05 08:18:28

Re: Openbox with rounded corners

#22 2017-01-05 18:39:02

Re: Openbox with rounded corners

#23 2017-01-05 22:32:48

Re: Openbox with rounded corners

#24 2017-01-06 01:52:08

Re: Openbox with rounded corners

#25 2017-01-06 05:38:10

Re: Openbox with rounded corners

#26 2017-01-07 18:51:11

Re: Openbox with rounded corners

#27 2017-01-07 19:52:39

Re: Openbox with rounded corners

#28 2017-01-07 21:40:55

Re: Openbox with rounded corners

#29 2017-01-07 22:37:37

Re: Openbox with rounded corners

#30 2017-01-08 06:57:19

Re: Openbox with rounded corners

#31 2017-01-08 11:42:27

Re: Openbox with rounded corners

#32 2017-01-08 18:17:48

Re: Openbox with rounded corners

#33 2017-01-09 02:35:29

Re: Openbox with rounded corners

#34 2017-01-09 03:38:55

Re: Openbox with rounded corners

#35 2017-01-09 03:54:44

Re: Openbox with rounded corners

#36 2017-01-09 05:53:59

Re: Openbox with rounded corners

#37 2017-01-09 07:21:24

Re: Openbox with rounded corners

#38 2017-01-09 07:27:22

Re: Openbox with rounded corners

#39 2017-01-09 07:41:08

Re: Openbox with rounded corners

#40 2017-01-09 07:44:55

Re: Openbox with rounded corners

Board footer