You are not logged in.

#101 2019-10-09 07:18:25

ohnonot
...again
Registered: 2015-09-29
Posts: 4,168
Website

Re: fortune notifications?

Dammit, I forgot to push the lastest changes.
Please try again (I laready tested on my AL machine, and very superficially on a BL vm - all seems to work OK).

BTW, was there a reason I set the notify-send urgency to "low"? I removed that now.
Optically there seems to be no difference on BL default theme.

and oh, one can checkout or pull the git repository as a whole, then switch to the soph_algo branch:

git checkout soph_algo

still learning git, me...

Offline

#102 2019-10-09 07:24:30

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 6,097
Website

Re: fortune notifications?

ohnonot wrote:

was there a reason I set the notify-send urgency to "low"?

I've no idea what that does, but if it's a legit option, then considering the urgency of quotes from the BL forums compared with, say, imminent battery failure, then you might as well continue setting it to "low" I guess.


John
--------------------
( a boring Japan blog, idle Twitterings and GitStuff )
In case you forget, the rules.

Offline

#103 2019-10-09 07:32:03

ohnonot
...again
Registered: 2015-09-29
Posts: 4,168
Website

Re: fortune notifications?

I think it only affects the style of the notification window, and the timeout (but since we explicitely define the timeout that's out).
Depending on the notification daemon, it might also affect other things I guess, but I'm aware of none.
But to my knowledge and experience all things using notifications (new mail, song change etc.) use default urgency; so I think bl-fortune should also do that.

Offline

#104 2019-10-09 07:39:44

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 6,097
Website

Re: fortune notifications?

^Fine.


John
--------------------
( a boring Japan blog, idle Twitterings and GitStuff )
In case you forget, the rules.

Offline

#105 2019-10-09 08:21:17

ohnonot
...again
Registered: 2015-09-29
Posts: 4,168
Website

Re: fortune notifications?

Can you please try to test the newest version at least a few times?

Offline

#106 2019-10-09 08:23:50

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 6,097
Website

Re: fortune notifications?

^What would you like me to test, in particular?


John
--------------------
( a boring Japan blog, idle Twitterings and GitStuff )
In case you forget, the rules.

Offline

#107 2019-10-11 04:35:04

ohnonot
...again
Registered: 2015-09-29
Posts: 4,168
Website

Re: fortune notifications?

^ that timing options don't collide and generally work as advertised.(*)
That it works on BL with XFCE-notification-daemon just as well as on my AL with dunst.
That the default icon is still visible (it needs to be installed somewhere, I think we discussed this earlier).
That it's possible to combine BL fortunes with other fortunes (-C option).
Thank You.

(*) I did not make this fool proof, the user will get what they put in on the command line. And with conflicting options the last one should win (AFAICS).

Offline

#108 2019-10-11 07:04:55

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 6,097
Website

Re: fortune notifications?

I don't know if I'll have the time to do all that any time soon to be honest. Lithium is overdue and there are some relatively important things to sort out.

Has all that changed since the last release? XFCE-notification-daemon | icon | -C option ?

If not, I can copy/paste the script itself into my own machine and check that it still does its thing for a few days, then do a package upgrade.

If such simple testing is not enough, maybe you can ask someone else to help, or for that matter, as the person with the greatest interest in this package, you could set up your own BL VM somewhere and run through that test programme?

Otherwise, we could just release Lithium with the old package still in place, ala Debian when "upstream" haven't pushed the changes...

EDIT: right off I can report:

bl-fortune -h wrote:

        -C <name>, --cookie='<name>[ name]'  set fortune cookie list(s)
                                    Default is cbbl
                                    This can contain multiple fortunes and
                                    options to fortune. Example:
                                    "-e cbbl fortunes"

john@helium:~$ bl-fortune -e cbbl fortunes
/home/john/bin/bl-fortune error: -e: no such option
john@helium:~$ bl-fortune -C cbbl fortunes
/home/john/bin/bl-fortune error: fortunes: no such option
 # single cookie OK
john@helium:~$ bl-fortune -C cbbl
john@helium:~$ bl-fortune -C fortunes

Last edited by johnraff (2019-10-11 07:15:02)


John
--------------------
( a boring Japan blog, idle Twitterings and GitStuff )
In case you forget, the rules.

Offline

#109 2019-10-12 06:31:24

ohnonot
...again
Registered: 2015-09-29
Posts: 4,168
Website

Re: fortune notifications?

^ I think you misunderstood me.
All I asked was to throw a few command line options at it, just to make sure it performs the same on a baremetal BL install.
Just now, that took me all of a few minutes on a BL vm; but it's always better to check from different setups, have more pairs of eyes on it.

I never asked only you personally to do all (or, in fact, any) testing.
This is a forum, everyone can read this, devs, users.
Anyone could've spared 5min to test this, yet none did.
It's a little sad but there we are.
So many are chanting praise for "The FOSS community" but never actually do anything for it, however small.

Nevermind, it's not like this package is important for system stability.

I have merged it now.

Of course that is not the end of the road, those willing to test can still help and I can still improve it.

johnraff wrote:

EDIT: right off I can report:

bl-fortune -h wrote:

        -C <name>, --cookie='<name>[ name]'  set fortune cookie list(s)
                                    Default is cbbl
                                    This can contain multiple fortunes and
                                    options to fortune. Example:
                                    "-e cbbl fortunes"

john@helium:~$ bl-fortune -e cbbl fortunes
/home/john/bin/bl-fortune error: -e: no such option
john@helium:~$ bl-fortune -C cbbl fortunes
/home/john/bin/bl-fortune error: fortunes: no such option
 # single cookie OK
john@helium:~$ bl-fortune -C cbbl
john@helium:~$ bl-fortune -C fortunes

I see. I thought the double quotes and the sentence "This can contain multiple fortunes and options to fortune" were self-explanatory.
The correct format would've been

bl-fortune -C "-e cbbl fortunes"

I have - hopefully - improved the help text a little.

Offline

#110 2019-10-12 08:52:02

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 6,097
Website

Re: fortune notifications?

I never asked only you personally to do all (or, in fact, any) testing.
This is a forum, everyone can read this, devs, users.

Yes, I misunderstood that.

I thought the double quotes and the sentence "This can contain multiple fortunes and options to fortune" were self-explanatory.
The correct format would've been

bl-fortune -C "-e cbbl fortunes"

I have - hopefully - improved the help text a little.

Thanks! That indeed works. It's amazing how different peoples' ideas as to what is obvious can... differ.

Anyway, I'll build and upload the new package soon - maybe tomorrow.


John
--------------------
( a boring Japan blog, idle Twitterings and GitStuff )
In case you forget, the rules.

Offline

#111 2019-10-13 07:19:45

ohnonot
...again
Registered: 2015-09-29
Posts: 4,168
Website

Re: fortune notifications?

johnraff wrote:

I never asked only you personally to do all (or, in fact, any) testing.
This is a forum, everyone can read this, devs, users.

Yes, I misunderstood that.

Actually I did address you personally in recent posts; I have to remember to phrase requests like this more generally in the future.

Offline

Board footer

Powered by FluxBB