You are not logged in.

#201 2016-08-23 16:52:05

damo
....moderator....
Registered: 2015-08-20
Posts: 4,833

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

xaos52 wrote:

^ Nice.
Upload the modified images to bl-exit/merlin?

All done smile

BTW, I also made sure that none of the png's had the transparent colour values saved - it made one of them display a bg in the Thunar thumbnail, although bl-exit was OK.


Be Excellent to Each Other...

FORUM RULES and posting guidelines «» Help page for forum post formatting
Artwork on DeviantArt  «» BunsenLabs on DeviantArt

Offline

#202 2016-08-23 17:19:38

damo
....moderator....
Registered: 2015-08-20
Posts: 4,833

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

DEBUG bl-exit theme config option windowWidthAdjustment is not an int

The default value needs to be

windowWidthAdjustment=0

Be Excellent to Each Other...

FORUM RULES and posting guidelines «» Help page for forum post formatting
Artwork on DeviantArt  «» BunsenLabs on DeviantArt

Offline

#203 2016-08-23 18:24:40

xaos52
The Good Doctor
From: Planet of the @pes
Registered: 2015-09-30
Posts: 695

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

^ Is a warning. When it is not an int, 0 is used.

Offline

#204 2016-08-25 03:16:07

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 5,149
Website

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

xaos52 wrote:

I feel that the latest version pushed to merlin solves most if not all mentioned problems.
Please try it out and prove me wrong smile

I'll do my best. smile

About the star - sorry, what religion did that invoke? I personally liked it...


John
--------------------
( a boring Japan blog , Japan Links, idle twitterings  and GitStuff )
In case you forget, the rules.

Offline

#205 2016-08-25 06:41:19

SabreWolfy
Member
Registered: 2016-08-23
Posts: 27

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

johnraff wrote:

... About the star - sorry, what religion did that invoke? I personally liked it...

Star and Crescent

Offline

#206 2016-08-25 08:21:58

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 5,149
Website

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

btw @damo those new "sleep" png files are much bigger now, can anything be done about that?

Updating 9ea6213..71fd8a4
Fast-forward
 dark/sleep.png                  | Bin 9061 -> 23709 bytes
 light/sleep.png                 | Bin 9471 -> 21986 bytes
 

John
--------------------
( a boring Japan blog , Japan Links, idle twitterings  and GitStuff )
In case you forget, the rules.

Offline

#207 2016-08-25 08:24:50

SabreWolfy
Member
Registered: 2016-08-23
Posts: 27

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

Sorry, guys neutral Go back to the old ones!

Offline

#208 2016-08-25 08:47:45

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 5,149
Website

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

@TheDoctor
The iconpath system seems sensible, but in bl-exitrc the icondir option has been dropped from the definitions of [dark] and [light] themes and replaced by iconpath of /usr/share/images/bunsen/exit/{dark,light}
Meanwhile the [Minimal] theme (still upper-case btw) uses an icondir of dark and an iconpath of /usr/share/images/bunsen/exit/light Something looks odd.
The comments say:

You can use your own images by placing them in a direcory of your
choice in your HOME directory. We recommend ~/.local/share/bl-exit

This looks good.
How about keeping iconpath as a global setting, and using individual icondirs for each theme? So users can put their eg "dark" directories in their iconpaths.

---

bl-exitrc wrote:

NB The "dark" directory contains light icons for a dark theme, and vice versa.

While agreeing that this should be the case, "dark" still contains dark icons, and vice versa.

---

Maybe add something in the comments about what a button show setting of "maybe" means?

---
I'm just about to actually try this out. To be honest, from looking at the code changes, it looks good.  cool


John
--------------------
( a boring Japan blog , Japan Links, idle twitterings  and GitStuff )
In case you forget, the rules.

Offline

#209 2016-08-25 10:30:55

pvsage
Internal Affairs
Registered: 2015-09-29
Posts: 1,433

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

johnraff wrote:

btw @damo those new "sleep" png files are much bigger now, can anything be done about that?

Updating 9ea6213..71fd8a4
Fast-forward
 dark/sleep.png                  | Bin 9061 -> 23709 bytes
 light/sleep.png                 | Bin 9471 -> 21986 bytes
 

Probably just re-saving with a lower Q factor or lower bit depth?

SabreWolfy wrote:

Sorry, guys neutral Go back to the old ones!

No, I consider this a valid issue.  The star in the sleep icon was redundant anyway IMHO.


Be excellent to each other, and...party on, dudes!
BunsenLabs Forum Rules
Tending and defending the Flame since 2009

Offline

#210 2016-08-25 10:54:42

xaos52
The Good Doctor
From: Planet of the @pes
Registered: 2015-09-30
Posts: 695

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

pvsage wrote:

No, I consider this a valid issue.  The star in the sleep icon was redundant anyway IMHO.

Valid issue indeed. I suspect the size is only a minor problem, easy to correct. damo?

Offline

#211 2016-08-25 16:00:30

damo
....moderator....
Registered: 2015-08-20
Posts: 4,833

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

Odd, I checked the file size after my first edit, and it was 7k, same as the others.

 $ file sleep.png 
sleep.png: PNG image data, 100 x 100, 8-bit/color RGBA, non-interlaced

Anyway, I found the last save had included exif data. Resaved with reduced size, and pushed to merlin branch.


Be Excellent to Each Other...

FORUM RULES and posting guidelines «» Help page for forum post formatting
Artwork on DeviantArt  «» BunsenLabs on DeviantArt

Offline

#212 2016-08-26 02:43:59

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 5,149
Website

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

^Thanks!

@xaos52 I've not been able to find any usage issues so far ... still trying.
Thanks for the tooltips.
  cool

EDIT windowWidthAdjustment works nicely as long as you don't try to squeeze it really small. Fine for its purpose.

EDIT2 In bl-exitrc

[style]
dir = styles
rcfile = blue.rc

No colour change, and:

john@bunsen1:~$ bl-exit
Loading theme 'Light Theme' by BunsenLabs
DEBUG bl-exit custom style rc file does not exist

/etc/bl-exit/styles/blue.rc does exist.

...aah but I now discover that the style directory has to be copied to ~/.config/bl-exit. Fair enough.

Last edited by johnraff (2016-08-26 03:30:44)


John
--------------------
( a boring Japan blog , Japan Links, idle twitterings  and GitStuff )
In case you forget, the rules.

Offline

#213 2016-08-26 06:32:13

xaos52
The Good Doctor
From: Planet of the @pes
Registered: 2015-09-30
Posts: 695

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

EDIT windowWidthAdjustment works nicely as long as you don't try to squeeze it really small. Fine for its purpose.

Leave the user some slack to mess it up, if that pleases her. smile

Introducing windowWidthAdjustment was a good idea. Can't remember who brought that up. wink

And the tooltips are not annoying at all. I changed my mind there.

Let me know when it is good enough to merge in deuterium.

Offline

#214 2016-08-27 07:03:50

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 5,149
Website

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

@DocX

johnraff wrote:

in bl-exitrc the icondir option has been dropped from the definitions of [dark] and [light] themes and replaced by iconpath of /usr/share/images/bunsen/exit/{dark,light}
The comments say:

bl-exitrc wrote:

You can use your own images by placing them in a directory of your
choice in your HOME directory. We recommend ~/.local/share/bl-exit

This looks good.
How about keeping iconpath as a global setting, and using individual icondirs for each theme? So users can put their eg "dark" directories in their iconpaths.

What do you think of having a single PATH-like iconpath setting for the whole script, and individual one-word icondir settings in each theme? So icondir would be appended to each path in iconpath and searched for icon names. That would fit with the comments in bl-exitrc, and I think it might be less work for users. Would it be a PITA to code, or have some disadvantage I haven't thought of?

---

This still needs doing:

bl-exitrc wrote:

NB The "dark" directory contains light icons for a dark theme, and vice versa.

While agreeing that this should be the case, "dark" still contains dark icons, and vice versa.


John
--------------------
( a boring Japan blog , Japan Links, idle twitterings  and GitStuff )
In case you forget, the rules.

Offline

#215 2016-08-27 10:09:29

xaos52
The Good Doctor
From: Planet of the @pes
Registered: 2015-09-30
Posts: 695

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

johnraff wrote:

What do you think of having a single PATH-like iconpath setting for the whole script, and individual one-word icondir settings in each theme? So icondir would be appended to each path in iconpath and searched for icon names. That would fit with the comments in bl-exitrc, and I think it might be less work for users. Would it be a PITA to code, or have some disadvantage I haven't thought of?

OK.
I can do this.
But the theme-specific 'icondir' setting should then be pre-pended to the  global 'iconpath' setting, no?

----

This still needs doing:

bl-exitrc wrote:

        NB The "dark" directory contains light icons for a dark theme, and vice versa.

    While agreeing that this should be the case, "dark" still contains dark icons, and vice versa.

My original thought was the same as yours, but I changed my mind and followed damo's original idea,  i.e. 'dark' images in the 'dark' folder - which seems more intuitive to me than the other way around.

Notice that 'dark' here refers to the images, not the theme.

A dark theme can have dark or light images. It is the users choice. Themes and images can be freely combined without restrictions.

So I propose to keep the directories as they are now and change the comment in bl-exitrc to remove the confusion.

Offline

#216 2016-08-28 09:03:26

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 5,149
Website

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

xaos52 wrote:
johnraff wrote:

What do you think of having a single PATH-like iconpath setting for the whole script, and individual one-word icondir settings in each theme?

OK.
I can do this.
But the theme-specific 'icondir' setting should then be pre-pended to the  global 'iconpath' setting, no?

I don't think so. Let's say the user has set, globally, iconpath to

~/.local/share/bl-exit:/usr/share/images/bunsen/exit

and a particular theme has an icondir of "dark".
Then bl-exit will search for the icon names needed, first in
~/.local/share/bl-exit/dark
then, if not found, in
/usr/share/images/bunsen/exit/dark
So icondir is appended to each path in iconpath, right?

---

This still needs doing:

bl-exitrc wrote:

        NB The "dark" directory contains light icons for a dark theme, and vice versa.
    While agreeing that this should be the case, "dark" still contains dark icons, and vice versa.

My original thought was the same as yours, but I changed my mind and followed damo's original idea,  i.e. 'dark' images in the 'dark' folder - which seems more intuitive to me than the other way around.
...
So I propose to keep the directories as they are now and change the comment in bl-exitrc to remove the confusion.

That would work too. There is a case for doing it that way, but I think other "dark" icon themes usually have light-coloured icons, suitable for dark themes. Anyway, it's your call.


John
--------------------
( a boring Japan blog , Japan Links, idle twitterings  and GitStuff )
In case you forget, the rules.

Offline

#217 2016-08-29 09:48:24

xaos52
The Good Doctor
From: Planet of the @pes
Registered: 2015-09-30
Posts: 695

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

johnraff wrote:

I don't think so. Let's say the user has set, globally, iconpath to

~/.local/share/bl-exit:/usr/share/images/bunsen/exit

and a particular theme has an icondir of "dark".
Then bl-exit will search for the icon names needed, first in
~/.local/share/bl-exit/dark
then, if not found, in
/usr/share/images/bunsen/exit/dark
So icondir is appended to each path in iconpath, right?

I prefer using iconpath to the way PATH is used: a colon separated list of absolute paths to directories to search from left to right. And if you want subdirectories from those directories searched as well, you have to add an entry to  the path, and explicitly specify the search order.

Your example can be configured using iconpath only:

iconpath = ~/.local/share/bl-exit/dark:/usr/share/images/bunsen/exit/dark

without possible confusion about how iconpath, icondir and the icon image name are combined by the program.

In fact every situation that uses iconpath and icondir combined can be solved by using iconpath alone.
So the icondir config option becomes superfluous. KISS principle applied. Eliminate superfluous config options, even it means having to type some more characters.

The only advantage iconpath + icondir provides is that it allows to type 'dark' only once. But users wanting to use custom icons will generally replace the complete set of icons with something more to their taste, and put them in a dir of their choice. The config can then be simplified to:

iconpath = ~/.local/share/bl-exit/dark

Offline

#218 2016-08-30 02:27:48

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 5,149
Website

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

Sure that will work too, and, agreed, if a user is changing the icons then they don't need a long, colon-separated list. A single path will be enough.

It's your call - let's keep it without icondir. (I liked it because I hate typing and prefer to type long paths only once.)

Maybe a little work on the comments at the top of bl-exitrc to make all this clearer?

EDIT: Anyway, let's merge Merlin into Deuterium soon. That will leave Merlin free for you to develop it further if you want. We can do any final tweaking in Deuterium.

Last edited by johnraff (2016-08-30 02:36:38)


John
--------------------
( a boring Japan blog , Japan Links, idle twitterings  and GitStuff )
In case you forget, the rules.

Offline

#219 2016-08-30 09:09:52

xaos52
The Good Doctor
From: Planet of the @pes
Registered: 2015-09-30
Posts: 695

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

johnraff wrote:

Maybe a little work on the comments at the top of bl-exitrc to make all this clearer?

Done

johnraff wrote:

EDIT: Anyway, let's merge Merlin into Deuterium soon. That will leave Merlin free for you to develop it further if you want. We can do any final tweaking in Deuterium.

Agreed.
Will merge tomorrow, unless there are objections by that time.

Offline

#220 2019-02-16 21:02:05

THX1138
Member
Registered: 2019-01-14
Posts: 191

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

Q1. Would you use that functionalty?
No. The reason being that I find operating systems that hibernate, or even sleep, my computers, fail to wake them up properly on resume. This has been the case since the very first hibernate/sleep function to the latest. I prefer to have my computers either on or off

I am not saying the function should not exist. I am simply saying I wouldnt use it, and believe if it did exist should not be set as default. I am fairly certain most people
find it useful but I just find it a pain

oops - embarrassment - never realised this was a revived thread and the conversation has probably moved on a lot from the original post

Last edited by THX1138 (2019-02-16 21:04:32)


The telephone is an antiquity - you never know who is calling, there is no image, it is an outmoded product which constantly disrupts work (Ralf Hutter (Kraftwerk)) ps: my wife knows how much I dislike being disrupted at Work - Ralf Hutter hit the nail on the head there

Offline

#221 2019-02-20 02:47:57

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 5,149
Website

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

Bearded_Blunder wrote:

@mods, should these last few posts be split to help & support?

Doing now...
...but to new topics in "Development & Suggestions".

But I'm afraid the i18n topic got lost somehow. Sorry.

Last edited by johnraff (2019-02-20 02:57:25)


John
--------------------
( a boring Japan blog , Japan Links, idle twitterings  and GitStuff )
In case you forget, the rules.

Offline

Board footer

Powered by FluxBB