[OBSOLETE] The bunsenlabs 'exit' menu entry

johnraff · 2016-08-20 04:05:24

johnraff wrote:

I still think it would be cleaner to have /usr/share/images/bunsen/exit checked first, followed by the config file dir (as now) if the style directory isn't found.

Of course I was wrong here. The user's local directory should be checked first, and if the icon with the name being searched for is not found, then check /usr/share/images/bunsen/exit
However, I'm not 100% sure if it's a Good Thing to have image files in ~/.config anyway - need to read up a bit on Debian Policy...
EDIT In fact, maybe ~/.local/share/bl-exit would be a more suitable place for users to put their personal icons, keeping any config files in~/.config/bl-exit?

damo wrote:

I'd like to see bl-exit(merlin) use the icontheme icons as default, as well as being able to use the bl-exit dark/light icons as a user option

This is interesting too. Would it be rather troublesome to allow the user to choose icons from their current icon theme, instead of the bl-exit icons? I guess the first problem would be icon names. Do most icon themes provide a set of logout/reboot/shutdown/suspend/etc icons, and is there a reliable convention on naming?

---
BUG?
*) No icon is defined for the "sleep" button in any theme, and the button does not appear, even if enabled in bl-exitrc and an icon defined. Looking at bl-exit there seems to be no behaviour defined for "sleep" anyway. What should it do that's different from "suspend"?

ANOTHER REQUEST
*) The full-screen-width appearance probably looks great on small-screen or hand-held devices, but on my 1440x900 it looks like overkill (to me). Some size or margin customization option(s)?

Last edited by johnraff (2016-08-20 04:23:51)

xaos52 · 2016-08-20 09:56:37

johnraff wrote:
I still think it would be cleaner to have /usr/share/images/bunsen/exit checked first, followed by the config file dir (as now) if the style directory isn't found.

I already have an 'icondir' config option.
I propose to change it to an 'iconpath', searching the directories in the path in the specified order.

damo wrote:
I'd like to see bl-exit(merlin) use the icontheme icons as default, as well as being able to use the bl-exit dark/light icons as a user option

Needs further investigation.
Aren't the icontheme icons too small?
Should they be blown up to a minimum size?
Is the solution with the iconpath not sufficient? Then the user can blow up whatever icon she wants to whatever size she wants and put it in whatever directory she wants.

BUG?
*) No icon is defined for the "sleep" button in any theme, and the button does not appear, even if enabled in bl-exitrc and an icon defined. Looking at bl-exit there seems to be no behaviour defined for "sleep" anyway. What should it do that's different from "suspend"?

The [sleep] entry in bl-exitrc should be removed. It is not queried for in the program - [suspend] is.
(xaos is my moniker - it sometimes shows )

ANOTHER REQUEST
*) The full-screen-width appearance probably looks great on small-screen or hand-held devices, but on my 1440x900 it looks like overkill (to me). Some size or margin customization option(s)?

Will add a theme specific option 'windowSizeAdjustment' - number of pixels to subtract from the monitor width to determine the window width.

@Damo and @Sector11:
The cancel button will be added to the default bl-exitrc.

----

BTW
You guys are tough customers - but no exception to the rule:
Minutes after I declare the program ready for prime time, I am overwhealmed with new requests.

damo · 2016-08-20 10:33:18

^ But your work is very much appreciated. Better to get it as polished as possible now, instead of too late!

xaos52 · 2016-08-20 12:00:12

^ Thanks, damo.
I am not complaining
And it is good for my python skills.

Sector11 · 2016-08-20 12:37:13

@xaos52 I really like the new exit menu. It's unique and the style simply beautiful.

xaos52 · 2016-08-20 15:02:11

@Sector11,
Credit for idea and style go to user 'MerlinElMago'.
I just incorporated his code in our bl-exit script, and made more options configurable.
And corrected his code here and there.

Sector11 · 2016-08-20 15:52:52

^ Thank you for pointing that out. Still looks GREAT!

Like the "yad" chooser script for conky - I found it on another distro, had a modified version I use here, very manual' and thought it would make for a nice Bunsen addition - damo turned it into a piece of magic far beyond my scripting abilities.

johnraff · 2016-08-21 01:29:02

damo wrote:

But your work is very much appreciated.

Yes!! Very much.

Better to get it as polished as possible now...

This is why I'm posting all these points. Much better now than after release.

johnraff · 2016-08-21 01:39:21

Thanks for looking at this, xaos.

xaos52 wrote:

johnraff wrote:
I still think it would be cleaner to have /usr/share/images/bunsen/exit checked first, followed by the config file dir (as now) if the style directory isn't found.
I already have an 'icondir' config option.
I propose to change it to an 'iconpath', searching the directories in the path in the specified order.

Sounds good. Please don't forget my self-correction above (#181), ie of course check locally first, then system default. What do you think of ~/.local/share/bl-exit as a path to check for icon directories?

ANOTHER REQUEST
*) The full-screen-width appearance probably looks great on small-screen or hand-held devices, but on my 1440x900 it looks like overkill (to me). Some size or margin customization option(s)?
Will add a theme specific option 'windowSizeAdjustment' - number of pixels to subtract from the monitor width to determine the window width.

Thanks!

Minutes after I declare the program ready for prime time, I am overwhelmed with new requests.

Yup! I guess you really could have used some more help with testing at an earlier stage. Maybe we need a dedicated thread to call for volunteer testers from the community for times like this?

johnraff · 2016-08-21 01:51:11

OMG YET ANOTHER REQUEST

If this would be unpleasant to code, forget it, but:
How about an optional [text] theme, perhaps based on [minimal], with icon settings replaced with things like

buttonTextCancel="CANCEL"

That would let you forget about tooltips? It might give you some headaches with formatting the text nicely though...

xaos52 · 2016-08-21 09:02:34

^ Will consider it

johnraff · 2016-08-22 01:01:37

...or, have the text strings available for all themes, and offer another "display" option?
icon only|icon with tooltip|icon with text|text only

I've no idea how PITA implementation would be, of course, just throwing out what I, as a user, might enjoy.

EDIT
Of course with the Deuterium release coming up soon, please feel free to decide what features/modifications to implement right now, and what can be left for a package upgrade later.

In fact, maybe we should merge Merlin into Deuterium fairly soon, finish the final bl-exit tweaks in Deuterium before merging it into Master, and leave Merlin free for further post-Deuterium development?

Last edited by johnraff (2016-08-22 01:06:46)

xaos52 · 2016-08-23 10:21:09

I really hesitate to say so, but I feel that the latest version pushed to merlin solves most if not all mentioned problems.
Please try it out and prove me wrong

Examples:
Not pretty, but showing the versatility of config options:

Combination of default and custom icons.

Using windowWidthAdjustment to squash the buttons together.

SabreWolfy · 2016-08-23 11:05:38

Could the middle icon be modified to look less religious?

pvsage · 2016-08-23 11:06:41

^ Remove the star maybe?

SabreWolfy · 2016-08-23 11:09:46

pvsage wrote:

^ Remove the star maybe?

I think so. Placing it anywhere else won't make much difference.

xaos52 · 2016-08-23 11:21:24

I need to consult my graphical 'help line' for this. damo?

BTW
Good to have you here again, SabreWolfy.

SabreWolfy · 2016-08-23 11:39:10

xaos52 wrote:

I need to consult my graphical 'help line' for this. damo?
BTW
Good to have you here again, SabreWolfy.

Thanks. Good to see so many of the old gang around! Just trying to familiarize myself with everything ...

damo · 2016-08-23 13:20:56

Easy enough to change. Looks OK to me in a VM...

Well done on the extra config options

xaos52 · 2016-08-23 16:19:52

^ Nice.
Upload the modified images to bl-exit/merlin?

#181 2016-08-20 04:05:24

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#182 2016-08-20 09:56:37

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#183 2016-08-20 10:33:18

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#184 2016-08-20 12:00:12

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#185 2016-08-20 12:37:13

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#186 2016-08-20 15:02:11

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#187 2016-08-20 15:52:52

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#188 2016-08-21 01:29:02

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#189 2016-08-21 01:39:21

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#190 2016-08-21 01:51:11

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#191 2016-08-21 09:02:34

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#192 2016-08-22 01:01:37

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#193 2016-08-23 10:21:09

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#194 2016-08-23 11:05:38

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#195 2016-08-23 11:06:41

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#196 2016-08-23 11:09:46

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#197 2016-08-23 11:21:24

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#198 2016-08-23 11:39:10

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#199 2016-08-23 13:20:56

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

#200 2016-08-23 16:19:52

Re: [OBSOLETE] The bunsenlabs 'exit' menu entry

Board footer