Neofetch: Wrong WM theme displayed (w/ fix)

hhh · 2023-10-07 17:25:35

I'm posting this in "Development" because, with a very quick check in a LIVE session, I don't see this issue on Beryllium. It must only effect neofetch versions 7.1.0-4 and up. You can see the issue and the fix here...

https://github.com/dylanaraps/neofetch/issues/2389

The easiest way to fix this on Boron is to copy /usr/bin/neofetch to ~/bin and edit the file there. In Boron/Bookworm the section begins at line #1967.

hhh · 2023-10-08 00:27:48

@rbh, re: https://github.com/dylanaraps/neofetch/ … 1751872439

I have not looked so much on the configuration. See now that I have line 'info "WM Theme" wm_theme' enabled, but i don't get info for "WM Theme".
Info for "DE", "WM" and "Theme" is shown correct.change after applying proposed patch.
There was no change after applying proposed patch.
Same on 4 different machines, one was a VM.

You're using neofetch version 7.1.0-4 on BL Boron? Have you changed your Openbox theme from the default? You need to in order to see this issue.

rbh · 2023-10-08 00:57:03

https://github.com/dylanaraps/neofetch/ … 1751876381

Sorry, even if ~/bin was first in path, command neofetch, wanted to run from /usr/bin/neofetch.
Running ~/bin/neofetch, gives correct info for "WM Theme".

I did a pull request of the patch.

hhh · 2023-10-08 01:20:55

rbh wrote:

https://github.com/dylanaraps/neofetch/ … 1751876381
Sorry, even if ~/bin was first in path, command neofetch, wanted to run from /usr/bin/neofetch.
Running ~/bin/neofetch, gives correct info for "WM Theme".
I did a pull request of the patch.

https://github.com/dylanaraps/neofetch/ … 5c20564275

Ah, thanks much! I don't have much hope for it, the maintainer seems to have abandoned the project.

Maybe John will want to add a custom neofetch file to ~/bin or package it at some point, one that includes this fix and the correct RAM info that we're including in the upcoming default conky, but it's really a very niche issue (not of interest to most users, I would think).

Thanks for helping with this!

johnraff · 2023-10-08 02:46:47

hhh wrote:

I'm posting this in "Development" because, with a very quick check in a LIVE session, I don't see this issue on Beryllium.

I had to apply your patch on Beryllium in order to see the correct OB theme.

Maybe John will want to add a custom neofetch file to ~/bin or package it at some point, one that includes this fix and the correct RAM info that we're including in the upcoming default conky, but it's really a very niche issue (not of interest to most users, I would think).

It is a bit niche, yes. Your fix would be easy to apply, so a cleanly patched package could go in our repo post-release some time. I'd have to look at the RAM section to see why it doesn't agree with conky (and inxi and top), if it's an easy fix it could go in too. But lowish on the priority list I guess.

rbh · 2023-10-08 08:55:12

hhh wrote:

I don't have much hope for it, the maintainer seems to have abandoned the project.
Maybe John will want to add a custom neofetch file to ~/bin or package it at some point,

Yes, no change to the code since 2021. A lot of work lying in the queue.

But, Neofetch is not an default BL application. Why then ship a patch to an abanded project?

And, is it really a problem?

On my 4 boxes I looked on, without your patch, command "/usr/bin/neofetch -vv 2" returns: "[!]\e[0m Info: Couldn'\''t detect WM Theme.", and that line does not show up on the screen.

Variabel "Theme" in neofetch, is read from ~/.gtkrc-2.0 or ~/.config/gtk-3.0/settings.ini, set by lxappereance.
Variabel "WM Theme", is by your patch, read from ~/.config/openbox/bl-rc.xml, set by obconf.

If both configs is set to same theme, they should show same. We recommend that same theme should be applied by both configs.
So, without hhh's patch, there is only "Theme" to show in neofetch...

unklar · 2023-10-08 10:03:24

johnraff wrote:

It is a bit niche, yes. Your fix would be easy to apply, so a cleanly patched package could go in our repo post-release some time. I'd have to look at the RAM section to see why it doesn't agree with conky (and inxi and top), if it's an easy fix it could go in too. But lowish on the priority list I guess.

I fully agree on the content, it is a 'niechen' problem and absolutely secondary to the release of Boron.

There is no correct RAM specification in Conky. Period.
First (until 1.12) it was fine with Conky, then it was broken, to finally reappear in several ways.
I think these statements here characterize this correctly.

This machine has 8GB RAM, a 4x2GB and I combined that into Conky.
BTW, @johnraff has already put that in the current BL-Boron-conky.

doas inxi -mxxx
Memory:
  System RAM: total: 8 GiB available: 7.76 GiB used: 809.8 MiB (10.2%)
  Array-1: capacity: 8 GiB note: est. slots: 4 modules: 4 EC: None
    max-module-size: 2 GiB
  Device-1: DIMM0 info: double-bank type: DDR2 detail: synchronous
    size: 2 GiB speed: 800 MT/s volts: N/A width (bits): data: 64 total: 64
    manufacturer: N/A part-no: N/A serial: N/A
  Device-2: DIMM1 info: double-bank type: DDR2 detail: synchronous
    size: 2 GiB speed: 800 MT/s volts: N/A width (bits): data: 64 total: 64
    manufacturer: N/A part-no: N/A serial: N/A
  Device-3: DIMM2 info: double-bank type: DDR2 detail: synchronous
    size: 2 GiB speed: 800 MT/s volts: N/A width (bits): data: 64 total: 64
    manufacturer: N/A part-no: N/A serial: N/A
  Device-4: DIMM3 info: double-bank type: DDR2 detail: synchronous
    size: 2 GiB speed: 800 MT/s volts: N/A width (bits): data: 64 total: 64
    manufacturer: N/A part-no: N/A serial: N/A

Last edited by unklar (2023-10-08 11:10:02)

hhh · 2023-10-08 14:28:17

I concur... leave this thread here and that'll be enough to satisfy us nerds for now.

johnraff · 2023-10-09 04:54:31

rbh wrote:

Variabel "Theme" in neofetch, is read from ~/.gtkrc-2.0 or ~/.config/gtk-3.0/settings.ini, set by lxappereance.
Variabel "WM Theme", is by your patch, read from ~/.config/openbox/bl-rc.xml, set by obconf.
If both configs is set to same theme, they should show same. We recommend that same theme should be applied by both configs.
So, without hhh's patch, there is only "Theme" to show in neofetch...

Not quite, the default 'neofetch' shows lines for both WM Theme and (GTK) Theme.
On my Beryllium system (I haven't checked Boron but expect the same), without @hhh's patch it shows:

WM Theme: BL-Lithium
Theme: Dragon [GTK2/3]
(so WM theme has been parsed from rc.xml, not bl-rc.xml)

and with the patch:

WM Theme: Dragon
Theme: Dragon [GTK2/3]

We would indeed generally recommend that the same theme be set for both WM and GTK, but they are two different things and it's not always possible. Some GTK themes have no OB theme of the same name, and vice versa. Users might choose their own combination.

#1 2023-10-07 17:25:35

Neofetch: Wrong WM theme displayed (w/ fix)

#2 2023-10-08 00:27:48

Re: Neofetch: Wrong WM theme displayed (w/ fix)

#3 2023-10-08 00:57:03

Re: Neofetch: Wrong WM theme displayed (w/ fix)

#4 2023-10-08 01:20:55

Re: Neofetch: Wrong WM theme displayed (w/ fix)

#5 2023-10-08 02:46:47

Re: Neofetch: Wrong WM theme displayed (w/ fix)

#6 2023-10-08 08:55:12

Re: Neofetch: Wrong WM theme displayed (w/ fix)

#7 2023-10-08 10:03:24

Re: Neofetch: Wrong WM theme displayed (w/ fix)

#8 2023-10-08 14:28:17

Re: Neofetch: Wrong WM theme displayed (w/ fix)

#9 2023-10-09 04:54:31

Re: Neofetch: Wrong WM theme displayed (w/ fix)

Board footer