Fixing bl-welcome translations

vinzv · 2018-01-03 22:19:18

Hi,

I just opened a pull request for bl-welcome to fix stuff left over from cb-welcome:
https://github.com/BunsenLabs/bunsen-welcome/pull/8

Unfortunately the generate-po script seems to not grab every string hidden in the bash files. I could dig through them and get the strings by myself but that's not intended I guess.
Maybe someone could have a look at generate-po?

Furthermore I already translated bl-welcome strings to German, at least as far as generate-po provided them.

Head_on_a_Stick · 2018-01-03 22:34:49

Thank you very much for this vinzv!

Unfortunately, the author of bl-welcome is currently unable to access the account directly so it may be few weeks before we can merge your changes but rest assured that we are dealing with them.

vinzv · 2018-01-03 22:42:47

Yeah, heard about the health issues. So no worries regarding time, just wanted to get this stuff stored safely somewhere.

jr2 · 2018-01-04 04:02:25

Thanks, @vinzv - this input is much appreciated.

Unia · 2018-01-04 08:25:55

vinzv wrote:

Unfortunately the generate-po script seems to not grab every string hidden in the bash files. I could dig through them and get the strings by myself but that's not intended I guess.
Maybe someone could have a look at generate-po?

My guess is that is it a simple matter of marking string as to-be-translated in the bl-welcome source files.

vinzv · 2018-01-04 17:22:03

Yeah, thanks @unia. It was easier to solve than I assumed in the first place! So I went through the whole bl-welcome code and streamlined single/double quotes usage.
I tested the result in a fresh helium VM which went fine.

For anyone interested and being keen enough to test here's the commit:
https://github.com/BunsenLabs/bunsen-we … 3561c6c55b

johnraff · 2018-01-18 08:42:27

Many thanks for your input vinzv.

In fact, the translation framework was put in by a previous contributor to the code, and I hadn't considered shipping translated versions of bl-welcome at all, to be honest. Many strings were added or changed, and only some of them received the $"....." treatment.

Anyway, I'll have a look at your changes, and merge them in if I can't spot any possible problems.

This of course raises the wider question of non-English versions of other parts of the BunsenLabs user interface - the menu, and a whole collection of scripts... Are we ready to take this on too?

johnraff · 2018-01-19 09:46:39

@vinzv I've had a look at your pull request - did you automate that process? There's a huge number of strings in there!
Anyway, it basically looks fine, but there are some details that would need fixing:

*) Sometimes I used dollared single quotes to make it easier to add linebreaks, eg $'first line\nsecond line' . This cannot just be substituted with double quotes, as you have done in some places, without providing the line-breaks in some other way, such as separate little $'\n' strings, or literal breaks inside strings, like $"first line
second line"

*) Sorry but I'm afraid you did some unnecessary work in processing files that are no longer used by the current bl-welcome script (see line 47) : deuterium-tweaks, add-multimedia-repo, check-repos. I'll remove those before the final release, but they were just left in for quick reference.

*) The quoting actually gets disrupted in "intro", on lines 10-20. It's impossible to translate the ASCII text section: ' _ _ _____ _ _ ___
| | | | ____| | | | / _ \
| |_| | _| | | | | | | | |
| _ | |___| |___| |__| |_| |
|_| |_|_____|_____|_____\___/

'
and "$logfile" is deliberately left out of the translated string, because it's a variable.

I'm not sure if it's time yet to devote any more effort to this, until we're sure that no more changes will be made to the whole package. In fact I do have a couple of things left on my to-do list for this.

Camiciaio Matto · 2018-01-23 08:36:12

I may help translate texts to italian, if it doesn’t require coding skills :D

#1 2018-01-03 22:19:18

Fixing bl-welcome translations

#2 2018-01-03 22:34:49

Re: Fixing bl-welcome translations

#3 2018-01-03 22:42:47

Re: Fixing bl-welcome translations

#4 2018-01-04 04:02:25

Re: Fixing bl-welcome translations

#5 2018-01-04 08:25:55

Re: Fixing bl-welcome translations

#6 2018-01-04 17:22:03

Re: Fixing bl-welcome translations

#7 2018-01-18 08:42:27

Re: Fixing bl-welcome translations

#8 2018-01-19 09:46:39

Re: Fixing bl-welcome translations

#9 2018-01-23 08:36:12

Re: Fixing bl-welcome translations

Board footer