[DONE] Improving BLOB for Boron

deleted0 · 2023-03-18 14:20:21

johnraff wrote:

I spent some time this morning looking for ways of adding a BBCode toolbar...

Now isn't the best time to risk upsetting the apple cart. As you said, focus is on the next release. That you are aware of the need is all I could ask for.

8bit

Last edited by deleted0 (2023-03-18 16:32:07)

deleted0 · 2023-03-18 15:09:25

johnraff wrote:

eight.bit.al wrote:
The issue from post #33, text change, was also covered originally in post #10; and apparently it was missed. I wasn't verbose enough about the change
The text change you suggested in post 10, I might have decided to ignore (or overlooked). It didn't seem to change that much.

Change from the original? From post #25

johnraff wrote:

Now: https://github.com/BunsenLabs/bunsen-ut … emes#L2215
Where did you get your code from?
---
Implemented part of your text suggestions (same url).

Yes, "part of your text suggestions". The link in the quote shows the text in question is still the old original one referring to a "Restore Button" which was renamed by this point. It needed to be changed and was missed. *

            --text="Double-click selection, or \"Enter\", or use the \"Restore\" button to restore settings\n" \

This is the first change I made; back in the original post #10. The change was spelled out in code blocks.

https://i.ibb.co/3NRx08v/main.png

            --text="Double-click selection, or \"Enter\", or \"Use Selected Blob\" button to apply settings.\n" \

This is the latest change of the line in question. It is built on the previous, original change, and made to be even more clear.

The text in post 33 spelled it out super clearly.
https://i.ibb.co/vvsdZ7B/change0.png
            --text="Double-click the highlighted selection, or use \"Enter\" key, or the \"Use Selected Blob\" button to apply selected blob\n" \

* A change that had to be made, submitted in code blocks was missed. The point I wished to be made at that time was not that something was missed, but that is there a better way to submit changes where things aren't missed?
^

8bit

Last edited by deleted0 (2023-03-18 15:16:16)

deleted0 · 2023-03-18 16:37:53

hhh wrote:

Go al!

Now is always a good time to share your ideas. No offering so small it can't be the seed for something great.

8bit

Last edited by deleted0 (2023-03-18 17:38:32)

johnraff · 2023-03-19 02:41:45

eight.bit.al wrote:

johnraff wrote:
eight.bit.al wrote:
The issue from post #33, text change, was also covered originally in post #10; and apparently it was missed. I wasn't verbose enough about the change
The text change you suggested in post 10, I might have decided to ignore (or overlooked). It didn't seem to change that much.

I implemented part of your suggestions from post 10 - the button labels and button order.
Yes, it looks as if I missed the change to the text at the top of the window. Sorry about that - it needed at least to agree with the new names of the buttons.

In my post 22 I reported

johnraff wrote:

Most of Al's recent changes, and a couple of mine and H's, uploaded. It's a test branch so no damage can be done:
https://raw.githubusercontent.com/Bunse … l-obthemes

That "most of" means that I decided not to implement some of it, but I now forget exactly what.

Change from the original? From post #25
johnraff wrote:
Now: https://github.com/BunsenLabs/bunsen-ut … emes#L2215
Where did you get your code from?

That link went back to an earlier point in the history, meant to show that the buttons had never had the wrong return values, ie 3 & 4 in the wrong places. I can't find any point in the recent history where the "save" button was 4 and "view" was 3. Still totally baffled as to where you got that.

Implemented part of your text suggestions (same url).
Yes, "part of your text suggestions". The link in the quote shows the text in question is still the old original one referring to a "Restore Button" which was renamed by this point. It needed to be changed and was missed.

Indeed. I was focussing on the buttons and missed the top.

A change that had to be made, submitted in code blocks was missed. The point I wished to be made at that time was not that something was missed, but that is there a better way to submit changes where things aren't missed?

Yes there is, it's called a Pull Request on GitHub. You make a personal fork of the repository on GitHub, make your edits there, and then click the Pull Request button. The original author (me in this case) reviews the suggested changes, and if they like them all, clicks the Merge button (or whatever it's called). If they want the PR to be changed they send back a comment, and the forker (you in this case) can edit and resend the PR. Pity GitHub don't keep the old merged PRs else I could show you one. There are no open PRs on bunsen-utilities, but here's one on bunsen-pipemenus that I sent in in 2021: https://github.com/BunsenLabs/bunsen-pipemenus/pull/62
The file in question had been written by another team member, and you can see the resulting conversation there. The other dev was ultimately unhappy with the changes I suggested, and the PR remained open, abandoned. I think it's time just to close it without merging. (If I have time I might try rewriting the "recent files" menu in bash using xmlstartlet.)

So you can make PRs for future suggestions if you prefer. GitHub has more detailed documentation.

Otherwise, in a thread like this, if you want to make life easier for careless developers you could add more explanation of exactly where your screenshots and code blocks have changed the existing code (as you finally had to do).

johnraff · 2023-03-19 02:57:39

Still to do for BLOB:

1) Split into its own package. I'll do this when all the changes are done.

2) Find a way to save GTK themes and icon themes separately. Shouldn't be hard, but if it is, I'll drop it.

3) Add a bit of code to save xfdesktop and pcmanfm config files if they're found to be running, and setting the wallpaper instead of nitrogen or feh. Same disclaimer as 2).

Couple of ideas I had, already dropped:

4) Save Grub boot screen background. It would be messy because the grub background can be set in various ways, also would need sudo.

5) Check if the wallpaper being used in a blob comes with a BL - or other - package and add that package to the blob's requirements. If the wallpaper is user added, then offer to save it in the blob directory. This is meant to make it easy to share blobs with other users just by tarring up ~/.config/blob/<blobname>, but again it looks a bit messy. Could be picked up again if users seemed to be sharing blobs...

6) Expand to work with other window managers than openbox. This would probably be a lot of work, and with Wayland coming along doesn't look worth the effort right now.

deleted0 · 2023-03-19 15:17:41

johnraff wrote:

Yes there is, it's called a Pull Request on GitHub.

I knew there had to be a more reliable method that what we were doing, at first.
Save the Pull Requests for tasks more complicated than a make-over of BLOB's looks.
Which is pretty much done, no?

8bit

Last edited by deleted0 (2023-03-19 16:12:43)

johnraff · 2023-03-20 04:43:44

Yes PRs are very good for handling suggested edits to big chunks of code, possibly over multiple files.

The BLOB interface looks good to me, much improved thanks to your and hhh's input. Unless anyone else has a suggestion, let's call it done.

I'll have a go at 2) & 3) listed above, then split it off from bunsen-utilities.

hhh · 2023-03-20 05:17:49

^ Agreed to done for now. It's been streamlined, good job. Going to have to finish the Yaru colors themes and upload them and the BLOBs, be patient.

johnraff · 2023-03-26 09:39:38

johnraff wrote:

Still to do for BLOB:
2) Find a way to save GTK themes and icon themes separately. Shouldn't be hard, but if it is, I'll drop it.

Done.
It wasn't hard but it took more code than I expected, especially after trying to cover errors and corner cases.
https://github.com/BunsenLabs/bunsen-ut … 4579635680

hhh · 2023-03-27 04:42:12

Are these improvements packaged yet? Sorry, I've manually replaced files so I don't know what the bunsen-utilities package includes ATM.

johnraff · 2023-03-27 08:10:51

Not packaged yet - BLOB is all in one file though, the latest version is always here:
https://github.com/BunsenLabs/bunsen-ut … l-obthemes
Copy it to ~/bin/bl-obthemes to see the latest improvements.

Just this left to do:

3) Add a bit of code to save xfdesktop and pcmanfm config files if they're found to be running, and setting the wallpaper instead of nitrogen or feh.

Then I'll split off bunsen-blob from bunsen-utilities and upload new versions of both packages.

hhh · 2023-03-28 04:49:53

Great, thanks!

johnraff · 2023-03-28 07:45:23

johnraff wrote:

...a bit of code to save xfdesktop and pcmanfm config files if they're found to be running, and setting the wallpaper instead of nitrogen or feh.

Are there any other apps that are commonly used* to set the wallpaper in WM based setups like BL?
Gnomey file managers like caja, dolphin, nautilus ??

* ie likely to be used by BL users instead of nitrogen or feh

Last edited by johnraff (2023-03-28 07:46:45)

johnraff · 2023-04-20 04:59:58

johnraff wrote:

Add a bit of code to save xfdesktop and pcmanfm config files if they're found to be running, and setting the wallpaper instead of nitrogen or feh.

It wasn't just a bit of code, but it's done. It's hard and unreliable to just save and restore the config files, so it uses xfconf-query for xfdesktop and a direct cli command for pcmanfm. For that to work, the actual wallpaper being used needs to be known, but that info is available at save time so is added to the blob's settings.cfg. The plus side is that even wallpapers set by tint2 or feh can later be restored by xfdesktop or pcmanfm. Also a test is run at restore time to see if the wallpaper actually exists - in future that might be extended to offering to install the package which provides a missing wallpaper.

BLOB has now been split off into a separate package bunsen-blob. It depends on bunsen-utilities, but bunsen-utilities does not need it, making bunsen-blob optional.

So the task of this thread has pretty much been done.

hhh · 2023-04-20 07:30:12

Brilliant work, Team.

or1o9 · 2023-04-20 16:33:44

Great work team, thanks.

#41 2023-03-18 14:20:21

Re: [DONE] Improving BLOB for Boron

#42 2023-03-18 15:09:25

Re: [DONE] Improving BLOB for Boron

#43 2023-03-18 16:37:53

Re: [DONE] Improving BLOB for Boron

#44 2023-03-19 02:41:45

Re: [DONE] Improving BLOB for Boron

#45 2023-03-19 02:57:39

Re: [DONE] Improving BLOB for Boron

#46 2023-03-19 15:17:41

Re: [DONE] Improving BLOB for Boron

#47 2023-03-20 04:43:44

Re: [DONE] Improving BLOB for Boron

#48 2023-03-20 05:17:49

Re: [DONE] Improving BLOB for Boron

#49 2023-03-26 09:39:38

Re: [DONE] Improving BLOB for Boron

#50 2023-03-27 04:42:12

Re: [DONE] Improving BLOB for Boron

#51 2023-03-27 08:10:51

Re: [DONE] Improving BLOB for Boron

#52 2023-03-28 04:49:53

Re: [DONE] Improving BLOB for Boron

#53 2023-03-28 07:45:23

Re: [DONE] Improving BLOB for Boron

#54 2023-04-20 04:59:58

Re: [DONE] Improving BLOB for Boron

#55 2023-04-20 07:30:12

Re: [DONE] Improving BLOB for Boron

#56 2023-04-20 16:33:44

Re: [DONE] Improving BLOB for Boron

Board footer