You are not logged in.

#21 2022-01-14 21:38:35

Bearded_Blunder
Dodging A Bullet
From: Seat: seat0; vc7
Registered: 2015-09-29
Posts: 979

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

There are a few things in that script you can't just skip, it's a complete NAZI that you absolutely must have your sources in apple pie order & be all apt updated etc. by it, or it never allows progressing past that.

Basically to progress to the goodies, dev metapackages extra wallpapers etc. etc. you have to agree to it "fixing" your sources, even on a system where that would actually break them.

I think stopping before it does apt update && apt upgrade on a system with devuan AND debian sources is the path of wisdom.

More info:

  Would you like to upgrade your software? [Y/n] 

Get:1 http://pkgmaster.devuan.org/merged chimaera-security InRelease [21.5 kB]
Hit:2 http://deb.devuan.org/merged chimaera InRelease
Get:3 http://deb.devuan.org/merged chimaera-updates InRelease [26.5 kB]
Hit:4 https://kelaino.bunsenlabs.org/~johnraff/debian beryllium InRelease
Fetched 48.0 kB in 5s (9,683 B/s)
Reading package lists...
  Finished update
  
  Checking apt sources... 
  
  The main Debian bullseye repository seems to be missing from your apt 
  sources. This can happen if an install is done without an internet 
  connection.
  This script can add the missing entry now, or you might prefer to exit and 
  edit /etc/apt/sources.list yourself. In that case, you can run this script 
  in a terminal later with the command 'bl-welcome'
Add the Debian main now? [Y/n] 


  Adding main Debian bullseye repository repo to apt sources...
  
/usr/lib/bunsen/welcome/apt-update-check-upgrade: line 64: src: unbound variable

/etc/apt/sources.list now

# deb cdrom:[Devuan GNU/Linux 4.0 chimaera amd64 - netinstall 20211012]/ chimaera contrib main non-free

#deb cdrom:[Devuan GNU/Linux 4.0 chimaera amd64 - netinstall 20211012]/ chimaera contrib main non-free

deb http://deb.devuan.org/merged chimaera main contrib non-free
deb-src http://deb.devuan.org/merged chimaera main contrib non-free

deb http://pkgmaster.devuan.org/merged chimaera-security main contrib non-free
deb-src http://pkgmaster.devuan.org/merged chimaera-security main contrib non-free

# chimaera-updates, to get updates before a point release is made;
# see https://www.debian.org/doc/manuals/debian-reference/ch02.en.html#_updates_and_backports
deb http://deb.devuan.org/merged chimaera-updates main contrib non-free
deb-src http://deb.devuan.org/merged chimaera-updates main contrib non-free

# This system was installed using small removable media
# (e.g. netinst, live or single CD). The matching "deb cdrom"
# entries were disabled at the end of the installation process.
# For information about how to configure apt package sources,
# see the sources.list(5) manual.

# added by bl-welcome on Fri 14 Jan 23:22:27 GMT 2022
# Debian main repository
deb https://deb.debian.org/debian bullseye main contrib non-free

I don't think I'd better do any apt upgrades with things in that condition.

Last edited by Bearded_Blunder (2022-01-14 23:29:51)


Blessed is he who expecteth nothing, for he shall not be disappointed...
If there's an obscure or silly way to break it, but you don't know what.. Just ask me

Offline

#22 2022-01-15 04:41:14

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 8,991
Website

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

Bearded_Blunder wrote:

I'm posting this as a direct result of trying on Devuan 4

There is in fact a test right at the start which checks /etc/debian_version against a regex. Did it not catch Devuan and exit? If not, what does Devuan put in /etc/debian_version?

Plenty of the script, pretty much all.. ought to work, provided it doesn't go adding debian sources to non debian distros.

While I'm happy if stuff I write can be used elsewhere than Debian, sorry but I'm not going to invest time into adding Devuan workarounds (especially not right now). Feel free to make a fork if you wish. smile


...elevator in the Brain Hotel, broken down but just as well...
( a boring Japan blog (currently paused), idle Twitterings and GitStuff )

Introduction to the Bunsenlabs Lithium Desktop

Online

#23 2022-01-15 05:33:49

Bearded_Blunder
Dodging A Bullet
From: Seat: seat0; vc7
Registered: 2015-09-29
Posts: 979

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

johnraff wrote:

There is in fact a test right at the start which checks /etc/debian_version against a regex. Did it not catch Devuan and exit? If not, what does Devuan put in /etc/debian_version?`

Apparently it didn't catch it. They put in there:

beardy@devuan-beryllium:/etc$ cat debian_version
11.1

Plenty of the script, pretty much all.. ought to work, provided it doesn't go adding debian sources to non debian distros.

While I'm happy if stuff I write can be used elsewhere than Debian, sorry but I'm not going to invest time into adding Devuan workarounds (especially not right now). Feel free to make a fork if you wish. smile

While I tested, I'm also not up for putting much effort in besides just on a whim running up a VM & seeing what happened, similar as it is, I've little to no actual interest in Devuan, just tested because we seem to get Devuan users on the forum quite often.

I'm *perfectly* content if bl-welcome puts up a message that it can only be run on Debian stable then exits.. that's the extent of the effort it's really worth.

I can add the log of most recent run if you want it, but the only thing that might be helpful from that is:

Checked repositories status.
Data:
declare -A repo_status=([unknown_7]=" 500 http://deb.devuan.org/merged chimaera-updates/main amd64 Packages" [bunsen_main]=" 500 https://kelaino.bunsenlabs.org/~johnraff/debian beryllium/main amd64 Packages" [unknown_19]=" 500 http://deb.devuan.org/merged chimaera/main amd64 Packages" [unknown_13]=" 500 http://deb.devuan.org/merged chimaera/non-free amd64 Packages" [unknown_10]=" 500 http://pkgmaster.devuan.org/merged chimaera-security/main amd64 Packages" [unknown_16]=" 500 http://deb.devuan.org/merged chimaera/contrib amd64 Packages" )

Don't really care about workarounds, certainly not at the expense of releasing late, do care about not damaging people's sources.list & potentially their install if they get the script pop up & just accept the default answers to see what's in it....


Blessed is he who expecteth nothing, for he shall not be disappointed...
If there's an obscure or silly way to break it, but you don't know what.. Just ask me

Offline

#24 2022-01-15 05:41:00

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 8,991
Website

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

Bearded_Blunder wrote:
johnraff wrote:

There is in fact a test right at the start which checks /etc/debian_version against a regex. Did it not catch Devuan and exit? If not, what does Devuan put in /etc/debian_version?`

Apparently it didn't catch it. They put in there:

beardy@devuan-beryllium:/etc$ cat debian_version
11.1

OK so that's the problem. Devuan's /etc/debian_version is identical with Debian's.
I guess they must have their own reasons for putting that there even though the system isn't Debian, but for bl-welcome it means looking for another way of testing for a Debian system. neutral

I was sure that nobody but Debian would have a debian_version file...

EDIT but on reflection, considering Devuan is intended to be as close to Debian as possible, without systemd, it seems unlikely there'll be anything there to test for.

bl-welcome doesn't enforce any apt sources changes though. Users who don't want to do what the script proposes are free to exit at any time. There's nothing on offer later in the script that the kind of user likely to be installing devuan won't be able to do for themselves.

Last edited by johnraff (2022-01-15 05:56:59)


...elevator in the Brain Hotel, broken down but just as well...
( a boring Japan blog (currently paused), idle Twitterings and GitStuff )

Introduction to the Bunsenlabs Lithium Desktop

Online

#25 2022-01-15 06:26:02

Bearded_Blunder
Dodging A Bullet
From: Seat: seat0; vc7
Registered: 2015-09-29
Posts: 979

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

Hard to think of anything completely bulletproof off the top of my head.

There's always the hack, use the test you're using & back it up with a quick grep for devuan or Devuan in sources.list...

Last edited by Bearded_Blunder (2022-01-15 06:28:03)


Blessed is he who expecteth nothing, for he shall not be disappointed...
If there's an obscure or silly way to break it, but you don't know what.. Just ask me

Offline

#26 2022-01-15 06:52:49

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 8,991
Website

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

^That doesn't appeal. Users can add whatever odd extra repos they want, for their own presumably good reasons. Specifically looking for Devuan and nothing else feels too hacky.

But:

Bearded_Blunder wrote:
/usr/lib/bunsen/welcome/apt-update-check-upgrade: line 64: src: unbound variable

You uncovered another bug - thank you!
There was a small glitch in the logical flow, now fixed in bunsen-welcome 11.3.1-1.


...elevator in the Brain Hotel, broken down but just as well...
( a boring Japan blog (currently paused), idle Twitterings and GitStuff )

Introduction to the Bunsenlabs Lithium Desktop

Online

#27 2022-01-15 15:04:42

Bearded_Blunder
Dodging A Bullet
From: Seat: seat0; vc7
Registered: 2015-09-29
Posts: 979

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

Perhaps there's something D-I puts in sources.list you could grep for "deb cdrom:[Debian" springs to mind, I believe it still puts that if you make a usb, that'll miss people who installed using debootstrap in a chroot, a very small minority, but unlike potentially foreign sources, the side effect is relatively harmless, bl-welcome just doesn't run in such cases.

It's still hackish, & still can misfire, thing being it'd misfire safely

Edit:

Next thought, Bunsen makes an install log right? Any way it could record what's in /etc/os-release (assuming it's going onto an installed system) and either grep the log or set a flag? That ought to be bulletproof if it could, or reasonably so..  it's not like /etc/os-release contains anything sensitive.

Last edited by Bearded_Blunder (2022-01-16 01:43:04)


Blessed is he who expecteth nothing, for he shall not be disappointed...
If there's an obscure or silly way to break it, but you don't know what.. Just ask me

Offline

#28 2022-01-16 02:59:05

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 8,991
Website

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

Bearded_Blunder wrote:

you could grep for "deb cdrom:[Debian" springs to mind, I believe it still puts that if you make a usb, that'll miss people who installed using debootstrap in a chroot, a very small minority...

There's also the debian base + metapackage install path - no (commented out btw) "CDROM" entry. That's how everyone using the current experimental Beryllium got there, so not an insignificant group. lol

but unlike potentially foreign sources, the side effect is relatively harmless, bl-welcome just doesn't run in such cases.

It's unfortunate that devuan try so hard to look like Debian. I'm wondering if there's any way of testing for a "real" debian system...

Even if bl-welcome could be hacked to run on devuan there's no guarantee that the metapackages it offered to install would work without tweaking the packages they bring. The only way I can see is a forked devuan version. Till then, bl-welcome will just have to go on to the list of packages that devuan users can't import from BL.

Bunsen makes an install log right?

No, the Debian-Installer makes a log. bl-user-setup and bl-welcome make logs too.

/etc/os-release

That is a possible alternative to /etc/debian_version. In fact bl-welcome used to check the output of 'lsb_release -cs'. At a certain point, though, that was - not unreasonably - giving "Lithium" instead of "Buster". Twoion wound back that improvement to return the debian codename instead of BL's, so bl-welcome would continue to work, but I later changed the test to debian_version so that future bunsen-os-release upgrades could honestly report the BL codename. I should have stayed with lsb_release, just accepting the BL codename as well as the Debian one, as I was thinking of doing back then: https://forums.bunsenlabs.org/viewtopic … 07#p105707

On your devuan system, what do 'cat /etc/os-release' and 'lsb_release -cs' return?

Last edited by johnraff (2022-01-16 03:13:31)


...elevator in the Brain Hotel, broken down but just as well...
( a boring Japan blog (currently paused), idle Twitterings and GitStuff )

Introduction to the Bunsenlabs Lithium Desktop

Online

#29 2022-01-16 03:57:05

Bearded_Blunder
Dodging A Bullet
From: Seat: seat0; vc7
Registered: 2015-09-29
Posts: 979

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

johnraff wrote:

There's also the debian base + metapackage install path - no (commented out btw) "CDROM" entry. That's how everyone using the current experimental Beryllium got there, so not an insignificant group. lol

Both "# deb cdrom [Debian ...... " and "#deb cdrom [Debian ...... " exist in my bog-standard default (systemd) Bullseye netinstall sources.list, installed using using the .iso image linked in the guide to install it, which is why it occurred to me. In the event of a completely offline install where apt doesn't get configured D-I doesn't comment them either, which is why I suggested plain grep without anchoring the thing to the ^beginning.

It's unfortunate that devuan try so hard to look like Debian. I'm wondering if there's any way of testing for a "real" debian system...

Agreed.

Even if bl-welcome could be hacked to run on devuan there's no guarantee that the metapackages it offered to install would work without tweaking the packages they bring. The only way I can see is a forked devuan version. Till then, bl-welcome will just have to go on to the list of packages that devuan users can't import from BL.

That'd be for someone who willingly runs Devuan to do, main point is, reliably stopping bl-welcome running so it doesn't interfere with Devuan sources.  With endless time someone might attempt making it agnostic of "Debian based" distro..

Causing it to plain abort on anything other than genuine Debian is a  "plenty good enough" fix in my opinion.

I only intended a brief experiment to see what happened, not get involved in trying to sort out problems in a distro I don't use, I'm a Debian/Bunsen & Windows user (even if I do go to pains to switch init) & the only other Linux distro that interests me is Gentoo, but I lack the hardware to run it sensibly with sane times compiling updates.  Or the skills to make it look nice.

No, the Debian-Installer makes a log. bl-user-setup and bl-welcome make logs too.

OK, I should have gone digging in the D-I log to see if there's anything useful in it to use as a test, I don't know whatall it logs, I might google where it is on the system later, I've never had cause to examine it, hence don't know.

/etc/os-release That is a possible alternative to /etc/debian_version. In fact bl-welcome used to check the output of 'lsb_release -cs'. At a certain point, though, that was - not unreasonably - giving "Lithium" instead of "Buster". Twoion wound back that improvement to return the debian codename instead of BL's, so bl-welcome would continue to work, but I later changed the test to debian_version so that future bunsen-os-release upgrades could honestly report the BL codename.

Interesting history.

On your devuan system, what do 'cat /etc/os-release' and 'lsb_release -cs' return?

To answer your questions though:

PRETTY_NAME="Devuan GNU/Linux 4 (chimaera)"
NAME="Devuan GNU/Linux"
VERSION_ID="4"
VERSION="4 (chimaera)"
VERSION_CODENAME="chimaera"
ID=devuan
ID_LIKE=debian
HOME_URL="https://www.devuan.org/"
SUPPORT_URL="https://devuan.org/os/community"
BUG_REPORT_URL="https://bugs.devuan.org/"

Which is useful now, but if Beryllium clobbers it the way Lithium did upon install it'll cease to be so.. unless that package sets a flag on install based off of what it replaced.

beardy@devuan-beryllium:~$ lsb_release -cs
chimaera

Last edited by Bearded_Blunder (2022-01-16 04:00:51)


Blessed is he who expecteth nothing, for he shall not be disappointed...
If there's an obscure or silly way to break it, but you don't know what.. Just ask me

Offline

#30 2022-01-16 05:09:33

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 8,991
Website

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

Bearded_Blunder wrote:
johnraff wrote:

There's also the debian base + metapackage install path - no (commented out btw) "CDROM" entry. That's how everyone using the current experimental Beryllium got there, so not an insignificant group. lol

Both "# deb cdrom [Debian ...... " and "#deb cdrom [Debian ...... " exist in my bog-standard default (systemd) Bullseye netinstall sources.list, installed using using the .iso image linked in the guide to install it, which is why it occurred to me.

Apologies, you're quite right. For a moment I forgot to reflect on where the base debian system had come from... ops

Causing it to plain abort on anything other than genuine Debian is a  "plenty good enough" fix in my opinion.

Agreed, and that has always been the intention - although with a greater emphasis on checking for the correct Debian release. Devuan has shown checking /etc/debian_version to be an inadequate test.

PRETTY_NAME="Devuan GNU/Linux 4 (chimaera)"
NAME="Devuan GNU/Linux"
VERSION_ID="4"
VERSION="4 (chimaera)"
VERSION_CODENAME="chimaera"
ID=devuan
ID_LIKE=debian
HOME_URL="https://www.devuan.org/"
SUPPORT_URL="https://devuan.org/os/community"
BUG_REPORT_URL="https://bugs.devuan.org/"

Which is useful now, but if Beryllium clobbers it the way Lithium did upon install it'll cease to be so.. unless that package sets a flag on install based off of what it replaced.

beardy@devuan-beryllium:~$ lsb_release -cs
chimaera

Thanks. Of course a Beryllium install will "clobber" /etc/os-release because bunsen-os-release is part of the BL package list. But, once again, somebody using devuan can't just blindly install the whole of BL and not expect issues. They'll have to leave bunsen-os-release out if they want their system to continue declaring itself to be devuan.

Meanwhile I think checking the output of 'lsb_release -cs' for either bullseye or beryllium ought to be a good enough test for bl-welcome. (And make lsb-release a dependency of bunsen-welcome - it's part of the BL package list anyway.)

Last edited by johnraff (2022-01-16 06:16:05)


...elevator in the Brain Hotel, broken down but just as well...
( a boring Japan blog (currently paused), idle Twitterings and GitStuff )

Introduction to the Bunsenlabs Lithium Desktop

Online

#31 2022-01-16 06:28:41

Bearded_Blunder
Dodging A Bullet
From: Seat: seat0; vc7
Registered: 2015-09-29
Posts: 979

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

Sounds good to me.

Off to see if I can break something else ;-)


Blessed is he who expecteth nothing, for he shall not be disappointed...
If there's an obscure or silly way to break it, but you don't know what.. Just ask me

Offline

#32 2022-01-16 07:49:04

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 8,991
Website

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

bunsen-welcome 11.4-1 uploaded.

Bearded_Blunder wrote:

Off to see if I can break something else ;-)

Please!


...elevator in the Brain Hotel, broken down but just as well...
( a boring Japan blog (currently paused), idle Twitterings and GitStuff )

Introduction to the Bunsenlabs Lithium Desktop

Online

#33 2022-01-17 05:37:51

Bearded_Blunder
Dodging A Bullet
From: Seat: seat0; vc7
Registered: 2015-09-29
Posts: 979

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

I've taken the liberty of marking this fixed, I certainly can't reproduce it anymore since the package last upgraded.

Last edited by Bearded_Blunder (2022-01-17 05:38:24)


Blessed is he who expecteth nothing, for he shall not be disappointed...
If there's an obscure or silly way to break it, but you don't know what.. Just ask me

Offline

#34 2022-01-17 05:57:04

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 8,991
Website

Re: [FIXED][Beryllium] bl-welcome offers to re-add contrib & non free.

^Thanks - you've saved me the effort.
A dev can always remove [FIXED] from a bug report if they feel it still needs work.


...elevator in the Brain Hotel, broken down but just as well...
( a boring Japan blog (currently paused), idle Twitterings and GitStuff )

Introduction to the Bunsenlabs Lithium Desktop

Online

Board footer

Powered by FluxBB