xfce4-power-manager systray icon missing on Debian Bullseye

ghorvath · 2021-02-25 20:00:13

ceeslans wrote:

DeepDayze wrote:

Then maybe a tint2 executor would be a good workaround to correct this "bug". Perhaps share your executor setup for this?

Here you go.
You can either set the icon path to the 'Papirus' panel icons in /usr/share/icons - or to the icon folder in ~/.config/tint2 (grab the archive in below link).
The script is set to the commonly used BAT0 levels. If so needed, change the path to BAT1.

~/.config/tint2/executors/battery

#!/bin/bash

iconpath="/usr/share/icons/Papirus-Dark/24x24/panel/"
#iconpath="$HOME/.config/tint2/executors/icons/battery/"

status=$(cat /sys/class/power_supply/BAT0/status)
perc=$(cat /sys/class/power_supply/BAT0/capacity)

if [[ $status = "Discharging" ]]; then
	if [[ $perc -ge 91 ]]; then
		echo "${iconpath}battery-full.svg"
		echo "$perc%"
	elif [[ $perc -ge 71 ]]; then
		echo "${iconpath}battery-good.svg"
		echo "$perc%"
		elif [[ $perc -ge 51 ]]; then
			echo "${iconpath}battery-medium.svg"
			echo "$perc%"
			elif [[ $perc -ge 31 ]]; then
				echo "${iconpath}battery-low.svg"
				echo "$perc%"
				elif [[ $perc -ge 16 ]]; then
					echo "${iconpath}battery-caution.svg"
					echo "$perc%"
					elif [[ $perc -ge 1 ]]; then
						echo "${iconpath}battery-empty.svg"
						echo "$perc%"
	fi

elif [[ $status = "Charging" ]]; then
	if [[ $perc -ge 90 ]]; then
		echo "${iconpath}battery-full-charging.svg"
		echo "$perc%"
	elif [[ $perc -ge 70 ]]; then
		echo "${iconpath}battery-good-charging.svg"
		echo "$perc%"
		elif [[ $perc -ge 50 ]]; then
			echo "${iconpath}battery-medium-charging.svg"
			echo "$perc%"
			elif [[ $perc -ge 30 ]]; then
				echo "${iconpath}battery-low-charging.svg"
				echo "$perc%"
				elif [[ $perc -ge 15 ]]; then
					echo "${iconpath}battery-caution-charging.svg"
					echo "$perc%"
					elif [[ $perc -ge 1 ]]; then
						echo "${iconpath}battery-empty-charging.svg"
						echo "$perc%"		
	fi

else
	echo "${iconpath}battery-full-charged.svg"
	echo "$perc%"
fi

tint2rc configuration for the battery executor (adept to your personal preferences)

#-------------------------------------
# Executor	(battery status)
execp = new
execp_command = ~/.config/tint2/executors/battery
execp_interval = 15
execp_has_icon = 1
execp_cache_icon = 0
execp_continuous = 0
execp_markup = 1
execp_tooltip = 
execp_lclick_command = b=$(acpi -b) && notify-send "$b"
execp_rclick_command = xfce4-power-manager -c
execp_mclick_command = 
execp_uwheel_command = 
execp_dwheel_command = 
execp_font = Noto Sans 8
execp_font_color = #eeeeee 100
execp_padding = 3 0 2
execp_background_id = 0
execp_centered = 0
execp_icon_w = 24
execp_icon_h = 24

here is the archive with the Papirus *.svg icons as called by the executor script.
~

This code doesn't give me the icons to the tint panel, only the percentage value. I do have the proper path for the icons, and when I run the executor from a terminal, it gives me the correct icon file path.

Is there something trivial I'm missing here?

The only change I did to the lithium default tint2 config file is this line:

panel_items = PTSBCP

and of course I added the lines above to the end of the tint2 config file.

What else would be needed from me so someone could help me troubleshoot this?

Thanks,
ghorvath

ceeslans · 2021-02-26 09:00:56

ghorvath wrote:

The only change I did to the lithium default tint2 config file is this line:
panel_items = PTSBCP
and of course I added the lines above to the end of the tint2 config file.
What else would be needed from me so someone could help me troubleshoot this?

Noticed that your panel_items line doesn't include an 'E' for the executor.
It should look something like this:

panel_items = PTESBCP

hope this helps

ghorvath · 2021-02-26 10:50:42

Noticed that your panel_items line doesn't include an 'E' for the executor.
It should look something like this:
panel_items = PTESBCP
hope this helps

This is exactly what I needed. Works perfectly now. Thanks!

kozimodo · 2021-05-29 00:20:11

I just installed Beryllium on a "new" laptop that I was gifted and it is not that the power manager icon is missing from the theme but that as pointed out by manyroads, it is black. A different tint2 configuration (lithium-light.tint2rc) works fine.

Last edited by kozimodo (2021-05-29 00:20:45)

johnraff · 2021-05-29 01:05:54

This issue still needs work, obviously.
Without a battery (ie AC only) I get the same "icon missing" icon with both regular lithium and lithium-light tint2s.

I need to install Beryllium on a real laptop to test the battery icon issue more. That is a bit complicated because of the encrypted drive I have...

Since we are already shipping a tweaked papirus icon theme with a couple of substituted icons, once we knew the icon names needed to make this work again it should be easy enough to add them in. Maybe even symlinks would be enough.

Does anyone know if xfce4-power-manager has changed recently?
Needs some more websearching maybe...

Last edited by johnraff (2021-05-29 01:12:15)

hhh · 2021-05-29 03:04:22

A big version jump, unless they changed their version scheme...

https://packages.debian.org/buster/xfce4-power-manager

https://packages.debian.org/bullseye/xf … er-manager

johnraff · 2021-05-29 07:49:15

^The latter I think, but there were a lot of changes between buster & bullseye.
That release came out in December but I couldn't see any commits after that whose titles looked at all relevant:
https://gitlab.xfce.org/xfce/xfce4-powe … its/master

The issue turns up here and there, but because it's a systray icon the xfce devs seem to be giving it low priority, as something only for hacked-together systems (like BL), not regular xfce which uses the xfce4 panel.

Some links (including a couple that appeared early in this thread):
https://gitlab.xfce.org/xfce/xfce4-powe … issues/104
https://forum.xfce.org/viewtopic.php?id=14578
https://bbs.archlinux.org/viewtopic.php?id=262003
https://github.com/PapirusDevelopmentTe … ssues/2484
https://github.com/PapirusDevelopmentTe … ssues/2615
https://forum.manjaro.org/t/battery-ico … ager/57775

There was a hint about making symlinks in the icon theme that might conceivably help...
Needs some more digging into upower?

DeepDayze · 2021-05-29 21:30:18

hhh wrote:

A big version jump, unless they changed their version scheme...
https://packages.debian.org/buster/xfce4-power-manager
https://packages.debian.org/bullseye/xf … er-manager

I think it's the versioning scheme that changed to bring it into line with XFCE.

hhh · 2021-05-29 22:45:11

^ Right, what John said, but still a bunch of upgrades.

kozimodo · 2021-07-12 13:42:52

johnraff wrote:

This issue still needs work, obviously.
Without a battery (ie AC only) I get the same "icon missing" icon with both regular lithium and lithium-light tint2s.

I recently tried the pocillo icon theme designed for the Ubuntu budgie desktop and it seems quite acceptable to me. It also has the advantage that it has an icon for system updates.

It is not available in the Debian repos but it could be easily built for the Bunsen repo.

johnraff · 2021-07-14 02:55:10

^Hi @kozimodo - does the icon for xfce-power-manager show correctly in the tint2 system tray when using the pocillo icons on a Debian Bullseye system?

kozimodo · 2021-07-14 12:19:32

Ah, never mind. Looking at it on my Bullseye system, the icon is also black.

Last edited by kozimodo (2021-07-14 12:29:46)

hhh · 2021-07-14 21:18:41

Posting the relevant bug report (maybe?)

https://gitlab.xfce.org/xfce/xfce4-powe … note_23489

johnraff · 2021-07-15 04:13:09

^That issue is in the list I posted a few posts above, but thanks for the reminder - there is a bit more to read there now.

For a moment I thought removing libxfce4panel-2.0-4 might do it, but no go. neutral

johnraff · 2021-07-16 00:37:59

Moving this issue to the top of my TODO list. We can't really ship Beryllium with that "image-missing" icon in the system tray.

Spent a good chunk of time yesterday with not much to show however. sad

If anyone runs into a hint somewhere, please share!

hhh · 2021-07-16 03:44:59

So not a missing icon somewhere, but a coding error? And the developer won't fix it because it's "legacy" left in for panels other than xfce4-panel, but it's broken on other panels? I'm on Cinnamon now, but I assume it's broken on BL using lxpanel as well.

What happens with xfce4-panel? I'll do some testing soon, John.

johnraff · 2021-07-16 05:03:50

hhh wrote:

So not a missing icon somewhere, but a coding error?

It's starting to look that way. For the battery state icons, people have posted substitutions that they say work (not tried yet) but I haven't seen any hints of an icon name that's supposed to fix the issue for a desktop on AC power.

And the developer won't fix it because it's "legacy" left in for panels other than xfce4-panel, but it's broken on other panels?

That's my take too Though he claims it's OK, and the icon is ac-adapter-symbolic. (I have checked, and there are icons with that name on my test system.)

I'm on Cinnamon now, but I assume it's broken on BL using lxpanel as well.

Testing with other panels with traditional systrays than BL's tint2 would be useful indeed. Lxpanel a good first candidate.

Today I'm going to clone the code from Salsa, poke around with a sharpened chopstick and see if anything at all interesting drops out. (Probably not.)

Then I'll install another panel with a systray and see how the icon looks there. My guess it that it's broken in all systrays but we need to check.

happens with xfce4-panel? I'll do some testing soon, John.

Thanks!
(xfce4-panel has moved from a systray to some other system whose name I forget (indicator?). Maybe the same as what Gnome use.)

johnraff · 2021-07-16 07:08:07

Hmm... I compared the code on Debian Salsa with the xfce repo on GitLab and it looks quite possible that this commit fixes the AC power icon: https://gitlab.xfce.org/xfce/xfce4-powe … 6e94e05b88

The error (if that's what was causing it) is in lines 257 and 269 of common/xfpm-power-common.c.

To test it will require patching the debian code with that commit and rebuilding locally, but I might give it a try...

EDIT yes it was that code - at least with that single commit applied I get a power icon - but it's black.

Maybe I'll try applying all the recent xfce commits and see if the debian repo will still build a package, and if the icon is the right colour. Anyway, it's a start...

Last edited by johnraff (2021-07-16 08:01:53)

johnraff · 2021-07-17 06:13:24

OK I've just uploaded a patched xfce4-power-manager ( version 4.16.0-1+iconpatch2 ) to the experimental Beryllium repo for testing.

I reverted the single commit to common/xfpm-power-common.c in the Bullseye package which was breaking the AC power icon. With the Papirus-Bunsen-Dark-Bluegrey icon theme chosen we now get the former ac-adapter-symbolic.svg ac-adapter.svg icon. (EDITED)

I haven't tested this with a laptop using battery icons though - any feedback will be much appreciated!
We still might have to tweak our icon theme to get that working.

And there's still the question of whether we should be shipping a patched version of this package at all...

Last edited by johnraff (2021-07-25 08:03:42)

unklar · 2021-07-17 10:09:34

Unfortunately, I do not have a beryllium installation on a laptop.
So I took the latest (test) installation from siduction with the lxde desktop.

I am now missing the papirus bunsen dark bluegrey icon theme.
Where can I find it? smile

kozimodo · 2021-07-17 13:09:47

johnraff wrote:

I reverted the single commit to common/xfpm-power-common.c in the Bullseye package which was breaking the AC power icon. With the Papirus-Bunsen-Dark-Bluegrey icon theme chosen we now get the former ac-adapter-symbolic icon.

Unfortunately, it doesn't seem to be working for me. I have Papirus-Bunsen-Dark-Bluegrey selected:
look and feel
But with battery power, I still have a black icon:
battery
I'm also not sure that it is working plugged into an outlet:
outlet
Is it supposed to be green?

       _,met$$$$$gg.          
    ,g$$$$$$$$$$$$$$$P.       ----------- 
  ,g$$P"     """Y$$.".        OS: Debian GNU/Linux 11 (bullseye) x86_64 
 ,$$P'              `$$$.     Host: MacBookAir6,2 1.0 
',$$P       ,ggs.     `$$b:   Kernel: 5.10.0-7-amd64 
`d$$'     ,$P"'   .    $$$    Uptime: 11 mins 
 $$P      d$'     ,    $$P    Packages: 1871 (dpkg) 
 $$:      $$.   -    ,d$$'    Shell: bash 5.1.4 
 $$;      Y$b._   _,d$P'      Resolution: 1440x900 
 Y$$.    `.`"Y$$$$P"'         DE: Xfce 
 `$$b      "-.__              WM: Openbox 
  `Y$$                        Theme: BL-Lithium [GTK2/3] 
   `Y$$.                      Icons: Papirus-Bunsen-Dark-bluegrey [GTK2/3] 
     `$$b.                    Terminal: tilix 
       `Y$$b.                 CPU: Intel i7-4650U (4) @ 3.300GHz 
          `"Y$b._             GPU: Intel Haswell-ULT 
              `"""            Memory: 1584MiB / 7897MiB

damo · 2021-07-17 17:50:18

unklar wrote:

...
I am now missing the papirus bunsen dark bluegrey icon theme.
Where can I find it?

The icon theme is on our github

hhh · 2021-07-17 18:32:11

^ https://github.com/BunsenLabs/bunsen-pa … /beryllium

https://github.com/BunsenLabs/bunsen-pa … lium/icons

johnraff · 2021-07-18 03:11:47

@all many thanks for testing!
Just to make sure - you have upgraded xfce4-power-manager to version 4.16.0-1+iconpatch2 from the experimental Beryllium repositories?
https://forums.bunsenlabs.org/viewtopic.php?id=7356

(btw if you've enabled that repository you can install the BL icon themes the regular way via apt.)

The patch I applied to xfce4-power-manager 4.16.0-1 was only to revert what was breaking the AC power icon. If battery icons are still also incorrect that will need further work, either to undo what broke it in x-p-m or to tweak our icon theme so it provides what x-p-m is looking for.

Is the battery icon broken when using other icon themes than Bunsen-Papirus-* ?

@kozimodo yes I think the icon for battery while charging is green in Papirus. It should turn white when fully charged.
But the black icon is wrong...

Last edited by johnraff (2021-07-18 06:48:53)

unklar · 2021-07-18 07:35:28

Thanks @damo, thanks @hhh. smile

Thank you @johnraff
i had a wrong package name yesterday for apt. That's why the package icon theme was not found. hmm
Yes, I have included your repo

inxi -r
Repos:     No active apt repos in: /etc/apt/sources.list 
           Active apt repos in: /etc/apt/sources.list.d/bunsen.list 
           1: deb https://kelaino.bunsenlabs.org/~johnraff/debian beryllium main
           No active apt repos in: /etc/apt/sources.list.d/dbgsym.list 
           Active apt repos in: /etc/apt/sources.list.d/debian.list 
           1: deb https://deb.debian.org/debian/ unstable main contrib non-free
           Active apt repos in: /etc/apt/sources.list.d/extra.list 
           1: deb https://packages.siduction.site/extra unstable main
           Active apt repos in: /etc/apt/sources.list.d/fixes.list 
           1: deb https://packages.siduction.site/fixes unstable main

the black icon is shown in the default configuration here on lxde with openbox

so it is still displayed after the change with bunsen-papirus-icon-theme

only a restart changes then the icon correctly to green, like @kozimodo

#26 2021-02-25 20:00:13

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#27 2021-02-26 09:00:56

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#28 2021-02-26 10:50:42

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#29 2021-05-29 00:20:11

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#30 2021-05-29 01:05:54

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#31 2021-05-29 03:04:22

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#32 2021-05-29 07:49:15

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#33 2021-05-29 21:30:18

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#34 2021-05-29 22:45:11

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#35 2021-07-12 13:42:52

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#36 2021-07-14 02:55:10

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#37 2021-07-14 12:19:32

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#38 2021-07-14 21:18:41

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#39 2021-07-15 04:13:09

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#40 2021-07-16 00:37:59

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#41 2021-07-16 03:44:59

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#42 2021-07-16 05:03:50

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#43 2021-07-16 07:08:07

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#44 2021-07-17 06:13:24

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#45 2021-07-17 10:09:34

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#46 2021-07-17 13:09:47

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#47 2021-07-17 17:50:18

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#48 2021-07-17 18:32:11

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#49 2021-07-18 03:11:47

Re: xfce4-power-manager systray icon missing on Debian Bullseye

#50 2021-07-18 07:35:28

Re: xfce4-power-manager systray icon missing on Debian Bullseye

Board footer