fortune notifications?

johnraff · 2018-06-22 07:45:03

OK I'll hold off doing anything else till your repo has settled into its final form.

ohnonot · 2018-06-22 10:02:21

preliminary tests in a Helium VM turned out fine so far.
I installed your provisional .deb: https://www.dropbox.com/s/9puk6z9vlsiqc … l.deb?dl=1(*)
cloned my repo.
symlinked the bl-fortune script to ~/bin.
uncommented the last line in autostart.
and logged out/in a couple of times.
it seems to be working fine.

here's a manual testing scrot:
https://i.imgur.com/8w40QFs.png

i don't see any problems here; the rest is discussion:
- are the timeout values ok?
- is the icon ok?

and, more general:
- why are notifications on the top right, where they cover the conky?
- are there enough cbbl fortunes so that this doesn't get old really fast?

(should the recent discussion in this thread be split off, and pushed to the top somehow, to get more people testing/answering?)

(*) i decided to split the notification summary off at the first colon ':' - this required very slightly editing a few fortunes, and me to stick to that format from now on.
so maybe your provisional .deb is out of date now.

Last edited by ohnonot (2018-06-22 10:08:28)

johnraff · 2018-06-23 03:22:36

Thanks for testing and improvements!

ohnonot wrote:

cloned my repo.
symlinked the bl-fortune script to ~/bin.

You did this to override the package's bl-fortune with your more recent one from the repo, so you could test your changes, right?

here's a manual testing scrot:
https://i.imgur.com/8w40QFs.png

Looks good - I like your change to the message formatting. Did the display times work out OK for you? I'll give your new bl-fortune script a run here too.

- why are notifications on the top right, where they cover the conky?

Default notification position - easily user editable though. Surely conky is getting covered by something all the time? (I use an on-demand conky myself, tied to a key and coming on top, in the centre, with an opaque background.)

- are there enough cbbl fortunes so that this doesn't get old really fast?

I did wonder this myself to be honest. I can offer a Tao-te-ching database to expand it a bit (ancient discussion with Rhowaldt on #!) and maybe we need to quickly drum up some more contributions, or look elsewhere for some more fortune files to add?
(fortune can pick from multiple databases, right?)

(should the recent discussion in this thread be split off, and pushed to the top somehow, to get more people testing/answering?)

Doesn't recent posting do that anyway? We're still on the original topic, I guess.

maybe your provisional .deb is out of date now.

Yes I'll put up a newer one for people to test soon.

ohnonot · 2018-06-23 08:42:13

johnraff wrote:

You did this to override the package's bl-fortune with your more recent one from the repo, so you could test your changes, right?

yes.
the fortunes used are the ones from the .deb.

Did the display times work out OK for you?

after some testing, i came up with this:

#~ It is said that average reading speed is ~250 words per minute for adults.
#~ That means 4.166667 words per second.
#~ I think it's fair to assume that the text should linger quite a bit longer,
#~ almost twice as long. make that 2.5 words per second, that's a delay of 400ms
#~ per word:
delay=400
add=5000 # let's add a few extra seconds to message expiry time

'delay' is configurable, 'add' not (yet), and beyond that one can still choose the -t option for a fixed expiry time.
actually now i think about it i'm not sure 'add' is really necessary, i guess i'll do some more testing to feel that out.

- are there enough cbbl fortunes so that this doesn't get old really fast?

I did wonder this myself to be honest. I can offer a Tao-te-ching database to expand it a bit (ancient discussion with Rhowaldt on #!) and maybe we need to quickly drum up some more contributions, or look elsewhere for some more fortune files to add?
(fortune can pick from multiple databases, right?)

yes, fortune can pick from multiple databases.
the option is alreadythere in bl-fortune.
maybe something to mention in ~/.config/openbox/autostart.

so nore's beaker face it is, then?
i think they effectively already gave permission to use it, but i'll pm them nevertheless.

johnraff · 2018-06-23 09:10:12

ohnonot wrote:

'delay' is configurable, 'add' not (yet), and beyond that one can still choose the -t option for a fixed expiry time.
actually now i think about it i'm not sure 'add' is really necessary, i guess i'll do some more testing to feel that out.

I tend to think a certain added fixed time will be needed just for the time to notice that a notification has popped up, before even starting to read it. In fact, if the fixed time is long enough, I'm not sure if it's really necessary to adjust it for fortune length at all. Would a bit of lingering be that annoying? It's your call though.

yes, fortune can pick from multiple databases.
the option is alreadythere in bl-fortune.
maybe something to mention in ~/.config/openbox/autostart.

That sounds like the easiest way to go.

so nore's beaker face it is, then?
i think they effectively already gave permission to use it, but i'll pm them nevertheless.

Sounds good.

ohnonot · 2018-06-23 09:19:13

johnraff wrote:

In fact, if the fixed time is long enough, I'm not sure if it's really necessary to adjust it for fortune length at all. Would a bit of lingering be that annoying? It's your call though.

we had that discussion here on the forums.
the quotes differ a lot in length.
of course one can always click on them if they linger too long, but the default 20s isn't really enough for the longest.
in any case, it's all user configurable - both the per-word delay, or the fixed timeout.

johnraff · 2018-06-24 02:55:20

ohnonot wrote:

johnraff wrote:
In fact, if the fixed time is long enough, I'm not sure if it's really necessary to adjust it for fortune length at all. Would a bit of lingering be that annoying? It's your call though.
we had that discussion here on the forums.

And I thought the consensus then was not to bother? But anyway:

the quotes differ a lot in length.
of course one can always click on them if they linger too long, but the default 20s isn't really enough for the longest.
in any case, it's all user configurable - both the per-word delay, or the fixed timeout.

Fair enough - let's do it.

nore · 2018-06-24 06:43:44

ohnonot wrote:

so nore's beaker face it is, then?
i think they effectively already gave permission to use it, but i'll pm them nevertheless.

From my point of view, do what you like with it (CC0), it was just a quick scratch made during conversation. But as it is recognizably based on a trademarked character owned by Disney, I hope it counts as a "derivative work" or "transformative use".

hhh · 2018-06-24 07:10:16

nore wrote:

ohnonot wrote:
so nore's beaker face it is, then?
i think they effectively already gave permission to use it, but i'll pm them nevertheless.
From my point of view, do what you like with it (CC0), it was just a quick scratch made during conversation. But as it is recognizably based on a trademarked character owned by Disney, I hope it counts as a "derivative work" or "transformative use".

Screw it, they can sue us.

ohnonot · 2018-06-24 09:34:50

i just wrote this to nore in a pm:

oh, i never thought about that.
i just researched if we're violating anyone's rights, and it's messy.
assuming we're talking about fan art here, i found:
https://www.quora.com/Is-fan-art-fan-fi … yrightable
https://www.plagiarismtoday.com/2010/05 … copyright/
https://www.youtube.com/watch?v=utM2q5XE7z4
of course most articles talk about US laws.
each of them states that for most cases there's absolutely no reason to worry, but essentially you cannot be 100% sure that the law is on your side...
nevertheless i will rename the icon to something not beaker, and that is that for me.
if you don't mind, i'd prefer to not put a seperate license on the icon?

how about bunsen_face.svg?

ohnonot · 2018-06-28 08:50:58

i wonder why this thread has stalled.

anyhow, the bl-welcome script is in a usable state now.
i decided to change the text formattinmg a little so that it will work with other fortunes as well.

i chose nore's icon for good now, and removed the free clipart icon from the repo.
the icon needs to be specified with its full path on the command line; i think the debian package manintainer will take care of moving it to the correct location so that it can be specified with its shortname.

unless someone discovers a bug / has some improvement etc, it's all good now from my side.

ohnonot · 2018-06-28 08:51:43

the bl-welcome script is in a usable state now.
i decided to change the text formattinmg a little so that it will work with other fortunes as well.

i chose nore's icon for good now, and removed the free clipart icon from the repo.
the icon needs to be specified with its full path on the command line; i think the debian package manintainer will take care of moving it to the correct location so that it can be specified with its shortname.

unless someone discovers a bug / has some improvement etc, it's all good now from my side.

johnraff · 2018-06-28 09:55:38

ohnonot wrote:

i wonder why this thread has stalled.

I was doing other stuff, and thought I'd wait till things had settled down at your end.

it's all good now from my side.

Cool - I'll build a new deb soon - maybe tomorrow.

ohnonot · 2018-06-30 08:21:21

ok!

johnraff · 2018-07-04 08:32:12

ohnonot wrote:

anyhow, the bl-welcome script is in a usable state now.
i decided to change the text formattinmg a little so that it will work with other fortunes as well.
i chose nore's icon for good now, and removed the free clipart icon from the repo.
the icon needs to be specified with its full path on the command line; i think the debian package manintainer will take care of moving it to the correct location so that it can be specified with its shortname.
unless someone discovers a bug / has some improvement etc, it's all good now from my side.

But where is all this stuff? I just went to your repo https://github.com/ohnonot/fortune-mod-cbbl , thinking to package up the next deb, and found only one commit, a month ago when you added grapefruit's quote.

ohnonot · 2018-07-04 09:09:10

^ c'mon johnraff, what are we discussing right this moment?
look at my signature.

also see posts #38 and #39.

Last edited by ohnonot (2018-07-04 09:11:44)

johnraff · 2018-07-04 09:54:49

^Ah indeed!
Tomorrow...

johnraff · 2018-07-08 06:03:05

OK I incorporated your changes in the renamed source repo here: https://github.com/BunsenLabs/bunsen-fortune
The "master" branch is a clone of yours, "helium" also, but has an added "debian" directory holding all the packaging information. A bunsen-fortune .deb built from that is available in the (now generally unused) helium-dev repo:

deb https://kelaino.bunsenlabs.org/~johnraff/debian helium main

or you can just grab it here: https://www.dropbox.com/s/e6y9dzurfk9ew … l.deb?dl=1

Uncomment the line in openbox/autostart and it works perfectly.

I just have a couple of small questions about implementation:
1) Maybe comment out the printf lines - aren't they mostly for bugfixing? Left in, the output will just go into .xsession-errors anyway.
2) Since you went to the trouble of adding colons to all the fortunes, why not use that to delimit the header, instead of taking the first one or two words?

ohnonot · 2018-07-08 08:36:28

johnraff wrote:

1) Maybe comment out the printf lines - aren't they mostly for bugfixing? Left in, the output will just go into .xsession-errors anyway.

ok, i made it an option now.
pushed it too.

2) Since you went to the trouble of adding colons to all the fortunes, why not use that to delimit the header, instead of taking the first one or two words?

becasue this breaks when using other fortunes.
i might evtl. add a test that goes back to colon-based separation if only cbbl cookies are used.

johnraff · 2018-07-09 01:30:19

ohnonot wrote:

johnraff wrote:
1) Maybe comment out the printf lines - aren't they mostly for bugfixing? Left in, the output will just go into .xsession-errors anyway.
ok, i made it an option now.
pushed it too.

Thanks!
And... something I just noticed, if you want to use printf instead of echo, I think the safer way is considered to be to explicitly format all the arguments as strings with '%s'.
IE perhaps:

debugging() {
    [[ "$debug" == 1 ]] && printf '%s' "$@"
}

So every word in "$@" will be treated as a string.

2) Since you went to the trouble of adding colons to all the fortunes, why not use that to delimit the header, instead of taking the first one or two words?
becasue this breaks when using other fortunes.

Ah, understood.

#41 2018-06-22 07:45:03

Re: fortune notifications?

#42 2018-06-22 10:02:21

Re: fortune notifications?

#43 2018-06-23 03:22:36

Re: fortune notifications?

#44 2018-06-23 08:42:13

Re: fortune notifications?

#45 2018-06-23 09:10:12

Re: fortune notifications?

#46 2018-06-23 09:19:13

Re: fortune notifications?

#47 2018-06-24 02:55:20

Re: fortune notifications?

#48 2018-06-24 06:43:44

Re: fortune notifications?

#49 2018-06-24 07:10:16

Re: fortune notifications?

#50 2018-06-24 09:34:50

Re: fortune notifications?

#51 2018-06-28 08:50:58

Re: fortune notifications?

#52 2018-06-28 08:51:43

Re: fortune notifications?

#53 2018-06-28 09:55:38

Re: fortune notifications?

#54 2018-06-30 08:21:21

Re: fortune notifications?

#55 2018-07-04 08:32:12

Re: fortune notifications?

#56 2018-07-04 09:09:10

Re: fortune notifications?

#57 2018-07-04 09:54:49

Re: fortune notifications?

#58 2018-07-08 06:03:05

Re: fortune notifications?

#59 2018-07-08 08:36:28

Re: fortune notifications?

#60 2018-07-09 01:30:19

Re: fortune notifications?

Board footer