You are not logged in.

#1 2016-07-05 23:27:23

cloverskull
Member
Registered: 2015-10-01
Posts: 307

Proposal: Let's see if we can programmatically fix volumeicon

Hey guys,

Volumeicon is open source, hosted on github, and looks relatively simple. Hypothetically, this being linux and all, we could fork the project, try to fix it ourselves, file a corresponding bug with Debian's bugtracker, and submit the fix. This could be our first BL community contribution to the Debian world. Anyone interested?

So, the error when trying to launch volumeicon without using some arbitrarily long delay is

ALSA lib pulse.c:243:(pulse_connect) PulseAudio: Unable to connect: Connection refused

volumeicon: alsa_backend.c:86: asound_get_volume: Assertion `m_elem != ((void *)0)' failed.

-- snip --

Gotta run, work time, but anyone else interested in just fixing this instead of finding some other software solution to a simple problem?

Offline

#2 2016-07-06 03:41:41

cloverskull
Member
Registered: 2015-10-01
Posts: 307

Re: Proposal: Let's see if we can programmatically fix volumeicon

Ok, so I downloaded the source from github, compiled it, and am launching it in a VM and it's working fine. Any tips on how I can force this to fail?

My understanding is that volumeicon -> pulseaudio -> alsa -> hardware. Is there a way to turn off alsa assertions and pulseaudio temporarily to force break this?

Offline

#3 2016-07-06 16:43:02

cloverskull
Member
Registered: 2015-10-01
Posts: 307

Re: Proposal: Let's see if we can programmatically fix volumeicon

Hey guys,

I spoke with Maato, the owner of volumeicon. He was able to reproduce the issue and he wrote some retry logic into the code. Those of you with arbitrary delay settings, can you apt-get purge volumeicon and build the latest source from github, revert to a 2 second delay, and see if it fixes it?

I can't break it in virtualbox manually but I think, if this works, it's a perfect solution that we could try to push upstream via filing a debian bug with suggested remediation to just update to the latest version.

Offline

#4 2016-07-06 18:58:59

cloverskull
Member
Registered: 2015-10-01
Posts: 307

Re: Proposal: Let's see if we can programmatically fix volumeicon

Hey guys, I'm all for threads forking into interesting conversations and all, but for the sake of the original intent of this thread (to programmatically fix volumeicon with retry logic) I think we may be good to go, I just need help testing it. Can someone please check out my earlier post and let me know if that works? I can't validate this in a virtualized environment and don't have any other way to test at this time, but it would be cool to confirm if this fix works and file a ticket with Debian to fix it for good. smile

Thanks!

Offline

#5 2016-07-06 19:17:55

Head_on_a_Stick
Member
From: London
Registered: 2015-09-29
Posts: 8,759
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon


“Et ignotas animum dimittit in artes.” — Ovid, Metamorphoses, VIII., 18.

Forum Rules   •   How to report a problem   •   Software that rocks

Offline

#6 2016-07-06 19:18:50

Head_on_a_Stick
Member
From: London
Registered: 2015-09-29
Posts: 8,759
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

cloverskull wrote:

Can someone please check out my earlier post and let me know if that works?

Give me a bit, I will look into it smile

Watch this post...

EDIT: It works!

Well done cloverskull, thank you for this smile

@Team -- try this out please.

Last edited by Head_on_a_Stick (2016-07-06 19:36:11)


“Et ignotas animum dimittit in artes.” — Ovid, Metamorphoses, VIII., 18.

Forum Rules   •   How to report a problem   •   Software that rocks

Offline

#7 2016-07-06 19:50:25

Head_on_a_Stick
Member
From: London
Registered: 2015-09-29
Posts: 8,759
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

cloverskull wrote:

revert to a 2 second delay

The new version works even without any delay at all smile


“Et ignotas animum dimittit in artes.” — Ovid, Metamorphoses, VIII., 18.

Forum Rules   •   How to report a problem   •   Software that rocks

Offline

#8 2016-07-06 19:57:12

cloverskull
Member
Registered: 2015-10-01
Posts: 307

Re: Proposal: Let's see if we can programmatically fix volumeicon

Sweet! Thanks! I'll update the author that his code works and we should figure out how to get Debian to test / upgrade this. Any ideas there? smile

Offline

#9 2016-07-06 20:06:38

Head_on_a_Stick
Member
From: London
Registered: 2015-09-29
Posts: 8,759
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

cloverskull wrote:

how to get Debian to test / upgrade this. Any ideas there? smile

I don't think Debian would consider a bug fix of this nature for stable but sid will accept new package versions as the developer pushes them out with testing following suit 10-14 days later if no critical bugs are discovered.

So the fixed package should hopefully be available for the next Debian release when stretch goes stable in August 2017 (ish).

This will coincide with the release of BunsenLabs Helium (we hope).

smile


“Et ignotas animum dimittit in artes.” — Ovid, Metamorphoses, VIII., 18.

Forum Rules   •   How to report a problem   •   Software that rocks

Offline

#10 2016-07-06 20:11:42

Horizon_Brave
Operating System: Linux-Nettrix
Registered: 2015-10-18
Posts: 1,473

Re: Proposal: Let's see if we can programmatically fix volumeicon

When you say "revert to a 2 second delay" that's just if you changed it in our autostart right?


"I have not failed, I have found 10,000 ways that will not work" -Edison

Offline

#11 2016-07-06 20:21:50

cloverskull
Member
Registered: 2015-10-01
Posts: 307

Re: Proposal: Let's see if we can programmatically fix volumeicon

@HoaS - Okee dokee, cool, sounds good to me. Intermittent idea: We package a deb ourselves for volumeicon and host it on the BL repos. Would that be a decent solution for the time being?

@Horizon_Brave - Yeah, basically I wanted to confirm that the fix works for people that have been forced to add a bizarre and arbitrary delay value to get volumeicon to start successfully.

Offline

#12 2016-07-06 20:30:44

Head_on_a_Stick
Member
From: London
Registered: 2015-09-29
Posts: 8,759
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

cloverskull wrote:

We package a deb ourselves for volumeicon and host it on the BL repos. Would that be a decent solution for the time being?

I don't package for the official BL repositories but I could host it on my own OpenSUSE Build Service repositories for people to try out.

I will set it up tomorrow smile


“Et ignotas animum dimittit in artes.” — Ovid, Metamorphoses, VIII., 18.

Forum Rules   •   How to report a problem   •   Software that rocks

Offline

#13 2016-07-07 02:43:48

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 6,543
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

cloverskull wrote:

We package a deb ourselves for volumeicon and host it on the BL repos.

While there is a small number of backported or recompiled packages in our repos, we are quite conservative about what gets added.
Some reasons:

  • It commits us to keeping up with any security updates and applying them to our package.

  • Fixing one bug sometimes causes others, which we would be responsible for fixing.

  • A small change might have unexpected effects elsewhere in the system.

For that reason, most of our locally compiled packages fall into one or more of these categories:
In the main repo:

  • The package has been built elsewhere and only needs repackaging for Debian Jessie.

  • The code change is small.

  • The package is unimportant with no influence on the rest of the system.

  • The package is important for BunsenLabs and the new version fixes an annoying issue.

In the backports repo:

  • The new version fixes an issue that might be annoying for some users.

  • The use of the new package is optional.

Which is not to say that adding an improved version of volumeicon is out of the question (perhaps in backports?) but the decision will not be taken lightly, and will need approval from the repo maintainer (twoion) and the team as a whole.


...elevator in the Brain Hotel, broken down but just as well...
( a boring Japan blog (currently paused), idle Twitterings and GitStuff )

Introduction to the Bunsenlabs Lithium Desktop

Offline

#14 2016-07-07 02:44:36

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 6,543
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

Head_on_a_Stick wrote:

I could host it on my own OpenSUSE Build Service repositories for people to try out.

I will set it up tomorrow smile

Please! I'll definitely give it a go.

One thing that will need checking is that the "retry" code doesn't go into an endless loop if pulseaudio isn't available.

Last edited by johnraff (2016-07-07 02:48:10)


...elevator in the Brain Hotel, broken down but just as well...
( a boring Japan blog (currently paused), idle Twitterings and GitStuff )

Introduction to the Bunsenlabs Lithium Desktop

Offline

#15 2016-07-07 02:50:52

cloverskull
Member
Registered: 2015-10-01
Posts: 307

Re: Proposal: Let's see if we can programmatically fix volumeicon

@johnraff - thanks for the explanation. A perfectly sane policy, leveraging the conflicting ideas about security vs agility. Makes perfect sense. Perhaps it can be a backport, agreed that would make sense, until the main debian repos catch up when Stretch goes stable.

One thing I'd prefer not to engage in would be testing every single volume tint2 daemon we come across looking for the perfect fit. Sound in linux is no fun at all. It would be cool to get to a "just works" solution and adopt that as a platform...but that's not my call, just my two cents. smile

Offline

#16 2016-07-07 03:03:47

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 6,543
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

cloverskull wrote:

One thing I'd prefer not to engage in would be testing every single volume tint2 daemon we come across looking for the perfect fit.

We've done quite a bit of that already. neutral
Of course one of the reasons for a DE like BunsenLabs (I think it's fair to call it a DE) is that the devs go through that kind of stuff so the users don't have to.

EDIT: ...and that's why "well I could make that myself from a Debian netinstall" is nonsense.

Last edited by johnraff (2016-07-08 02:27:05)


...elevator in the Brain Hotel, broken down but just as well...
( a boring Japan blog (currently paused), idle Twitterings and GitStuff )

Introduction to the Bunsenlabs Lithium Desktop

Offline

#17 2016-07-07 21:15:39

Head_on_a_Stick
Member
From: London
Registered: 2015-09-29
Posts: 8,759
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

Head_on_a_Stick wrote:

I could host it on my own OpenSUSE Build Service repositories for people to try out.

I will set it up tomorrow smile

I'm struggling a bit with it so I will have to try again tomorrow...
sad

Sorry for the delay.


“Et ignotas animum dimittit in artes.” — Ovid, Metamorphoses, VIII., 18.

Forum Rules   •   How to report a problem   •   Software that rocks

Offline

#18 2016-07-08 22:07:47

Head_on_a_Stick
Member
From: London
Registered: 2015-09-29
Posts: 8,759
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

The packages are built!
smile

Here is the link:
https://software.opensuse.org/download. … volumeicon

I had some issues with the nomenclature so the package has a different name from the Debian version but the binary is the same so the Debian volumeicon-alsa package must be removed before installing this version.


“Et ignotas animum dimittit in artes.” — Ovid, Metamorphoses, VIII., 18.

Forum Rules   •   How to report a problem   •   Software that rocks

Offline

#19 2016-07-08 22:11:04

hhh
Meep!
Registered: 2015-09-17
Posts: 9,296
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

Rebooting into BL!

Offline

#20 2016-07-08 22:12:49

cloverskull
Member
Registered: 2015-10-01
Posts: 307

Re: Proposal: Let's see if we can programmatically fix volumeicon

w00t! Will test this weekend smile Thanks!

Offline

#21 2016-07-09 04:38:39

johnraff
nullglob
From: Nagoya, Japan
Registered: 2015-09-09
Posts: 6,543
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

Head_on_a_Stick wrote:

the package has a different name from the Debian version but the binary is the same so the Debian volumeicon-alsa package must be removed before installing this version.

@HoaS You can force the uninstallation of volumeicon-alsa with these lines in debian/control:

Conflicts: volumeicon-alsa
Replaces: volumeicon-alsa

However...
I tested the new package, and results on this machine suggested there might still be a little scope for optimization:
*) Scroll to change volume does not work.
*) Volume keybinds do not work.
*) Volume notifications do not appear.

None of these issues exists with the vanilla Jessie version, making this fix perhaps the most attractive, followed by a backported Stretch pnmixer.


...elevator in the Brain Hotel, broken down but just as well...
( a boring Japan blog (currently paused), idle Twitterings and GitStuff )

Introduction to the Bunsenlabs Lithium Desktop

Offline

#22 2016-07-09 06:56:03

hhh
Meep!
Registered: 2015-09-17
Posts: 9,296
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

hhh wrote:

Rebooting into BL!

And promptly fell asleep. Tomorrow, fo' sho'!

Offline

#23 2016-07-09 09:38:51

Head_on_a_Stick
Member
From: London
Registered: 2015-09-29
Posts: 8,759
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

johnraff wrote:

@HoaS You can force the uninstallation of volumeicon-alsa with these lines in debian/control:

Conflicts: volumeicon-alsa
Replaces: volumeicon-alsa

Yes indeed, thanks smile

I was thinking that last night as I fell asleep, funnily enough big_smile

And yes, I think "pulseaudio --start && volumeicon &" should fix this for us anyway.


“Et ignotas animum dimittit in artes.” — Ovid, Metamorphoses, VIII., 18.

Forum Rules   •   How to report a problem   •   Software that rocks

Offline

#24 2016-07-09 09:40:39

Head_on_a_Stick
Member
From: London
Registered: 2015-09-29
Posts: 8,759
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

johnraff wrote:

However...
I tested the new package, and results on this machine suggested there might still be a little scope for optimization:
*) Scroll to change volume does not work.
*) Volume keybinds do not work.
*) Volume notifications do not appear.

Gah! I forgot to compile it with "--enable-notify"  mad

New version incoming...
roll


“Et ignotas animum dimittit in artes.” — Ovid, Metamorphoses, VIII., 18.

Forum Rules   •   How to report a problem   •   Software that rocks

Offline

#25 2016-07-09 12:34:24

Head_on_a_Stick
Member
From: London
Registered: 2015-09-29
Posts: 8,759
Website

Re: Proposal: Let's see if we can programmatically fix volumeicon

I have added "Conflicts" & "Replaces" and tried to add "--enable-notify" [1] but that doesn't seem to be working -- I'm not sure if this is because of a build error on my part (highly likely) or a separate bug.

The new package version should be in the repositories by now soon so just `sudo apt update && sudo apt upgrade` to get them or download the new .deb files directly wink

Apologies for the sloppy packaging, I haven't bothered bumping the version number or editing the changelog hmm

[1] I added these lines to debian/rules:

override_dh_auto_configure:
        dh_auto_configure -- --enable-notify

EDIT: the build failed 'cos of that override so that can't be right sad

Investigating...

EDIT2: The packages now conflict with & replace volumeicon-alsa but notifications are not yet enabled.

If we decide to go with this modified package over the stock jessie version I will attempt to enable that option.

Last edited by Head_on_a_Stick (2016-07-09 13:24:02)


“Et ignotas animum dimittit in artes.” — Ovid, Metamorphoses, VIII., 18.

Forum Rules   •   How to report a problem   •   Software that rocks

Offline

Board footer

Powered by FluxBB